uwblueprint / sistering

Sistering's volunteer scheduling and management web application.
https://volunteer.sistering.org
8 stars 0 forks source link

Update weekly calendar view to restrict invalid start #638

Closed MatoPlus closed 2 years ago

MatoPlus commented 2 years ago

Ticket link

Closes #614

Implementation description

Steps to test

  1. As a super admin, login and go to create new posting page
  2. You should not be able to select shifts on days before the start date (we still allow it for recurring events lasting over than 1 week to allow uneven schedules)

What should reviewers focus on?

Checklist

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit edbcef3):

https://sistering-dev--pr638-rickson-schedule-shi-ke93pmhv.web.app

(expires Mon, 29 Aug 2022 02:03:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

MatoPlus commented 2 years ago

Tested in preview, seems like some days are missing in the calendar when startDate and endDate aren't on the same week for None recurrence frequency e.g. Can't see Sunday or Monday image

I don't think there's any actionable item to follow on this edge case within our time frame (eg: full month calednar). As discussed, we can probably ignore it?