Update navbar logout to manually clear auth token and refresh - Githubissues

uwblueprint / sistering

Sistering's volunteer scheduling and management web application.

https://volunteer.sistering.org

8 stars 0 forks source link

Update navbar logout to manually clear auth token and refresh #639

Closed MatoPlus closed 1 year ago

MatoPlus commented 1 year ago

Ticket link

Closes #626

Implementation description

Update navbar logout action to manually clear auth token in local storage + refresh instead of hard-blocking on backend call. ie: revoke token when possible, but it's not a priority if it fails

Steps to test

Logout still works for all logged in roles

What should reviewers focus on?

Correctness

Checklist

[x] My PR name is descriptive and in imperative tense
[x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
[x] I have run the appropriate linter(s)
[x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 1467927):

https://sistering-dev--pr639-rickson-update-logou-mwd72dko.web.app

_{(expires Mon, 29 Aug 2022 16:29:05 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

MatoPlus commented 1 year ago

merge since the change seems pretty small