Update better toast msg of delete branch failure toast - Githubissues

uwblueprint / sistering

Sistering's volunteer scheduling and management web application.

https://volunteer.sistering.org

8 stars 0 forks source link

Update better toast msg of delete branch failure toast #640

Closed MatoPlus closed 1 year ago

MatoPlus commented 1 year ago

Ticket link

Closes #575

Implementation description

Update toast msg description to be static - usually when a user fails to delete a toast, it is because there are existing postings that is still using the branch, the error tells the user to clear those references before proceeding to delete a branch

Steps to test

Log in as super admin, try to delete a branch that is used by a toast, you should see the toast error in the screen shot
Try creating a new branch and assign yourself to that branch, you should still be able to delete that branch without any error toast

What should reviewers focus on?

Any scenarios where this toast error would not make sense - this solution is a tradeoff for simplicity. I can't really see any other internal error scenarios that would cause this issue atm.

Checklist

[x] My PR name is descriptive and in imperative tense
[x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
[x] I have run the appropriate linter(s)
[x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 97d3d97):

https://sistering-dev--pr640-rickson-branch-delet-xy7y2z5r.web.app

_{(expires Tue, 30 Aug 2022 20:30:16 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

MatoPlus commented 1 year ago

merging small change for launch