uwblueprint / sistering

Sistering's volunteer scheduling and management web application.
https://volunteer.sistering.org
8 stars 0 forks source link

Create a SearchSelectorField to replace the current SelectorField for adding skills #663

Closed twilkhoo closed 1 year ago

twilkhoo commented 1 year ago

Ticket link

Closes #502

Implementation description

Steps to test

  1. Login as any user and edit profile
  2. Add skills using the new SearchSelectorField component, which includes selecting existing skills and creating new ones
  3. Save changes, if testing with the firebase hosting link you may get an authentication error since backend changes don't show in the preview
  4. To verify the skills are saved to the db, you can run the contents of this branch locally

What should reviewers focus on?

Checklist

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 25ee0d0):

https://sistering-dev--pr663-tejas-update-skills-fgu5cep8.web.app

(expires Mon, 05 Sep 2022 22:18:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

twilkhoo commented 1 year ago

Regarding the acronyms comment, I suppose that is a limitation with converting everything to title case. If we were to avoid converting to title case however, we would likely have lots of case differences in the db (some users may enter things all lowercase, some all uppercase, etc.). Due to this, I think that keeping the title case conversion outweighs the downsides.