search

uwhvz / uwhvz

The current UWaterloo Humans vs Zombies website, built with Django.
https://uwhvz.uwaterloo.ca
MIT License
5 stars 2 forks source link

Initial API #21

Closed tig567899 closed 4 years ago

tig567899 commented 4 years ago

Returns player data if the user is authenticated in the website.

tig567899 commented 4 years ago

I would like @pkrshnan to read over these changes before merging

Yep that was the intent - no rush - the client side isn't close to finished

pkrshnan commented 4 years ago

Couple big issues I see with this PR that I'd like to see changed before it goes further:

  1. The API login page shouldn't be able to be viewed through a browser, i.e it should be returning a 204 No Content, not an HTTP 200.
  2. There should be docs written somewhere about how to test this API, maybe even in this PR.
  3. This branch needs to be rebased off master, and should be in a separate branch entirely.

These are in addition to all the other comments on the PR. Looks good so far!

tig567899 commented 4 years ago

Closing this PR in favour of the new branch I opened. Will update API documentation.