search

valyala / fasthttp

Fast HTTP package for Go. Tuned for high performance. Zero memory allocations in hot paths. Up to 10x faster than net/http
MIT License
21.91k stars 1.76k forks source link

Socks proxy doesn't seem to support auth? #1627

Closed bennyd87708 closed 1 year ago

bennyd87708 commented 1 year ago

Currently have a working example program with a call to fasthttpproxy.FasthttpHTTPDialer for http proxies with auth using the format user:pass@address:port. I tried to switch this to fasthttpproxy.FasthttpSocksDialer, as I would like to also support socks proxies, but it seems as though this other function may only take in proxies with the format socks5://address:port, and that there is no support for username and password authentication with socks proxies. Is this intentional or is there any chance/plans for this feature to be supported any time soon? Thanks for the help regardless

erikdubbelboer commented 1 year ago

fasthttpproxy.FasthttpSocksDialer uses proxy.FromURL which also supports socks5://user:pass@address:port so it should just work.

bennyd87708 commented 1 year ago

That did it - Thanks!