RequestCtx forces the usage of a logger

[gaby]

Looking at the Init() code from RequestCtx if nil is passes it defaults to using golangs native logger which adds latency.

Here https://github.com/valyala/fasthttp/blob/master/server.go#L2720

func (ctx *RequestCtx) Init(req *Request, remoteAddr net.Addr, logger Logger) {
    if remoteAddr == nil {
        remoteAddr = zeroTCPAddr
    }
    c := &fakeAddrer{
        laddr: zeroTCPAddr,
        raddr: remoteAddr,
    }
    if logger == nil {
        logger = defaultLogger
    }
    ctx.Init2(c, logger, true)
    req.CopyTo(&ctx.Request)
}

Is this something that could be removed or avoided?

Related to https://github.com/gofiber/fiber/issues/3130

[gaby]

This can be avoided using:

type NOOPLogger struct{}

func (NOOPLogger) Printf(ctx context.Context, format string, v ...interface{}) {
    // Do nothing here
}

But it adds overhead to the RequestCtx for no reason. Anything we can do about this ? @erikdubbelboer

[erikdubbelboer]

Changing this would in theory break backwards compatibility. It's such a minor thing and your NOOPLogger is a good solution that I think we should just leave it as is.