vanvalenlab / kiosk-frontend

DeepCell web application built using NodeJS, Express, React, and Webpack.
Other
1 stars 0 forks source link

The /upload route uses a lot of synchronous execution. #107

Closed willgraf closed 3 years ago

willgraf commented 4 years ago

Using --trace-sync-io to monitor the usage of synchronous code, it seems that the uploading route uses a LOT of synchronous code through the gcs-resumable-upload package's dependency on configstore. This can result in performance issues for the backend.

willgraf commented 3 years ago

This exact issue was already brought up here, which was closed as it is being tracked here.

I'm going to close this issue, noting that it may be resolved in future releases of gcs-resumable-upload.