search

vanvalenlab / kiosk-frontend

DeepCell web application built using NodeJS, Express, React, and Webpack.
Other
1 stars 0 forks source link

Add Job Cards to provide useful information for each supported job type. #145

Closed willgraf closed 3 years ago

willgraf commented 3 years ago

Display an example image and a brief description of the inputs for each job type.

This is currently hardcoded in src/Predict/jobData.js and will need to be updated for future job types until this information is provided by the backend API. This could eventually be brought into the /api/jobtypes route.

This PR also breaks the Predict component into several smaller components:

Fixes #138 Fixes #122

ngreenwald commented 3 years ago

image

This looks awesome! Couple suggestions:

  1. Change "Download" to "Download example image" or something like that
  2. Change capitalization in Upload Here to Begin... so that only first word is capitalized
  3. Change "Drag and Drop" to "Drag and drop"
  4. Change "Job Type" to "Model" or something less technical feeling
  5. Is it possible to display the Mesmer example image as a 2-color image?
  6. Maybe changing the title to be something like "Generate model predictions"
willgraf commented 3 years ago

@ngreenwald Great suggestions! I've incorporated them all except 2 and 4, and the changes are live.

  1. I've left the capitalized title because the other labels are also capitalized ("Rescale Automatically").

  2. I've not changed it to "Job Type" because I did not like the look of just "Model".

ngreenwald commented 3 years ago

Okay awesome! Can you change the dropdown to Mesmer? Also, could we add a link somewhere in the FAQ to intro-to-deepcell? Maybe the "where can I get help" section?

"For an overview of the DeepCell ecocystem, please see our introductory documentation

willgraf commented 3 years ago

Good idea with the FAQ.

The dropdown value will be changed on the deployment, the job types are injected as environment variables, so they cannot be changed in this PR.