search

vecnet / dl-discovery

Map based discovery interface for digital library records
Other
4 stars 3 forks source link

A HREF for URL in record view is incorrect for displayed string - need to fix "URL" #47

Closed nkmeyers closed 9 years ago

nkmeyers commented 9 years ago

The A HREF value for URL in record view is not the same as displayed text string (for simulations at least) but the A HREF value in the "More details section" is good.

Fix the first instance, determine if URL needs to be repeated as here?

<dt>URL</dt>
<dd><a href="/catalog/2658">https://ci-qa.vecnet.org/ts_emod/simulation/details/run/2658/</a></dd>

<!--TODO: Fish out the correct links from JSON object here || Check with Don -->
  <dt>More details at</dt>
  <dd itemprop="url"><a href="https://ci-qa.vecnet.org/ts_emod/simulation/details/run/2658/">https://ci-qa.vecnet.org/ts_emod/simulation/details/run/2658/</a></dd>

image

stevenvandervalk commented 9 years ago

Field names and values will reflect the data dictionary : https://docs.google.com/document/d/1-lL3JakA5MQUrn8PqMoI1k_4McefUBF0G4R0wQoD_Po/edit#.

Let me know if you prefer different naming or urls.

By 4a2243f6b20b429b6c14a48207014af71695cabf. Not in qa-deploy yet but shortly.

stevenvandervalk commented 9 years ago

Local URLs like /catalog/ could be because they are empty in the hash so should check for empty first before adding to page DD.

stevenvandervalk commented 9 years ago

Ok fixed in feature branch to be merged later today.