vecnet / dl-discovery

Map based discovery interface for digital library records
Other
4 stars 3 forks source link

Update UI for default error pages and auth and routing error handling #92

Closed stevenvandervalk closed 9 years ago

stevenvandervalk commented 9 years ago

as per https://github.com/vecnet/dl-discovery/issues/77

dbrower commented 9 years ago

Should the error html pages use partials?

stevenvandervalk commented 9 years ago

Yes and yes. I think Rails should render 404 or 500 to all other errors so we don't need a catch-all or a rescue_from. My mistake I've removed that line and error_controller.

I don't think you can put anything in those error html pages besides plain HTML so no partials. If we redirect to other pages we can but.