search

veda-consulting-company / uk.co.vedaconsulting.outlookapi

Other
4 stars 18 forks source link

Activiy ID not found for translated environments #69

Open pbatroff opened 4 years ago

pbatroff commented 4 years ago

In translated environments, the Extension throws the error Invalid Activity ID, this might cause attachments not being saved. This is because the translated activity names are used to create a new activity, but the api fails with it.

Reproduction: Rename Activity Phone call to Anruf (German translation), and try to add an activity from outlook to a contact.

Tested Version: 2.5.1 and 3.0.4 (latest release) on both client and API with CiviCRM 5.19.3 and CiviCRM 5.20.0

pbatroff commented 4 years ago

I created a patch to fix this and soon will have a PR, leaving the default behaviour in place in case the mapping doesn't work. Otherwise the activity_id will be used as a parameter to create an activity.

I need to properly test this first.