search

vedderb / bldc-tool

A Qt program to control and debug my BLDC-controller
247 stars 220 forks source link

Updating README to include qt5 specification #14

Closed Winter-Guerra closed 8 years ago

Winter-Guerra commented 8 years ago

This is required for the build of BLDC-Tool. Otherwise, lots of errors occur.

TimGremalm commented 8 years ago

I don't think sudo is required to run BLDC-tool, and you should avoid using sudo when it's not necessary. Just make sure your user is a member of dialout so BLDC-tool have the right to open a serial connection. I think you should edit your pullrequest and remove sudo. Add something like this instead: sudo adduser $USER dialout

TimGremalm commented 8 years ago

The syntax highlighting is nice, easier to read.

Winter-Guerra commented 8 years ago

@TimGremalm Thanks for the pointer! I've updated the README to show how to access the serial port without sudo. Note that the restart is required, else the serial port still has access permission errors in Ubuntu 16.04LTS.

Winter-Guerra commented 8 years ago

@TimGremalm PING

TimGremalm commented 8 years ago

I'm guessing you want it merged. I think only @vedderb can push to this repo. The changes looks good. :)