vedderb / bldc-tool

A Qt program to control and debug my BLDC-controller
247 stars 220 forks source link

Made window scrollable in height. #17

Closed MarvinBaral closed 7 years ago

MarvinBaral commented 8 years ago

Tests:

Additional unexpected features:

Fixes #16

MarvinBaral commented 7 years ago

How about a pull? Its just a scrollbar. And this scrollbar disappears if there is no need to scroll.

MarvinBaral commented 7 years ago

Please, pull it. Or at least describe why you don't wat to.

vedderb commented 7 years ago

Thanks for the contribution. The reason that I haven't accepted any pull requests is that BLDC Tool will be replaced by VESC Tool very soon, which is a complete rewrite and much more suitable for shared development. For example, I have a bit improved version of BLDC Tool that I used while creating VESC Tool, and merging this pull with my local version is almost impossible since the the whole UI is in a big autogenerated XML file. To merge it I would have to look at what you have changed and make the same changes in the UI editor manually on my version. VESC Tool is very modular, so it is a lot easier for developers to work on different parts at the same time.

I would prefer people to wait a for VESC Tool rather than upgrading BLDC Tool. For now you can just use your repo if you need to use BLDC Tool on a small screen until VESC Tool is released, which scales to smaller screens much better than BLDC Tool.

MarvinBaral commented 7 years ago

Ok, nice. I'm looking forward towards the release of the VESC Tool.