Closed doapp-ryanp closed 7 years ago
I like being able to override or add arbitrary values to the hit (see #14) but are you sure you're GetTitle() is not working correctly? I just tested on two different channels and they both report the manifest 'title' value verbatim.
@cdthompson are you testing in market apps or looking at dev app in telnet log? I get this in dev when looking at the telnet output:
Here is my manifest:
title=ryan
major_version=1
minor_version=0
build_version=0
mm_icon_focus_fhd=pkg:/images/icon-fhd.png
mm_icon_focus_hd=pkg:/images/icon-hd.png
mm_icon_focus_sd=pkg:/images/icon-sd.png
splash_screen_fhd=pkg:/images/splash-fhd.png
bs_libs_required=roku_ads_lib
ui_resolutions=fhd
First line of my Main.rb
:
Function Main() as void
app_info = CreateObject("roAppInfo")
?"";app_info. GetTitle()
...
Output:
roku
I'm testing a dev channel on the console. Here's an example:
Brightscript Debugger> ai = CreateObject("roAppInfo")
Brightscript Debugger> print ai
<Component: roAppInfo>
Brightscript Debugger> print ai.GetTitle()
Veeta Brightscript REPL
Are you using the Eclipse IDE or some unique method of sideloading your channel?
I'm using https://atom.io/packages/roku-develop (plugin for atom IDE). When I use eclipse it does the same thing.
When I print ai.gettitle()
from debugger console it always prints roku
too.
I look at the manifest inside the built zip and name is there. I know my manifest is working because the app icon and splash img is working.
I'm running newest roku stick on newest firmware. What are you on?
Are you always deploying by the plugin? Can you upload the zip file manually through the Roku's web interface? Then you'll know there isn't any "magic" happening when you deploy.
I tested on a Roku 3 running 7.5.0 firmware.
Yup using plugin for atom and eclipse.
No dice using web interface. Still reports roku
. I'll post something to forum. I'll report back here if someone responds to wtf may be going on.
Closing this PR. Was error on my part. Didn't know a project could have multiple manifest files.
For others that run across this, see https://forums.roku.com/viewtopic.php?f=34&t=98622&p=549337#p549337
According to [Roku Docs](https://sdkdocs.roku.com/display/sdkdoc/ifAppInfo#ifAppInfo-GetTitle()AsString)
app_info.GetTitle()
should return "the title value from the manifest."I am not seeing this, at least in development.
app_info.GetTitle()
always returnsroku
. This really is messing up validation of metrics in dev/testI'd propose that the
initGAMobile()
take an optional 3rd param that lets you override app name.