Hide growth session topics for sessions that have past

vehikl / vehikl-growth-sessions

General weekly view of social mob activities

6 stars 3 forks source link

Hide growth session topics for sessions that have past #220

Closed IthJ closed 1 year ago

IthJ commented 1 year ago

Addressing Issue: https://github.com/vehikl/vehikl-growth-sessions/issues/204

With Topics

Without Topics

Would love feedback/suggestions

Milozap commented 1 year ago

This Pr checks if growth session is from yesterday and then hides their topics right? Do you think it would be better to add a filter for full growth sessions (for example 4 out of 4) in this PR or the next one?

IthJ commented 1 year ago

This Pr checks if growth session is from yesterday and then hides their topics right? Do you think it would be better to add a filter for full growth sessions (for example 4 out of 4) in this PR or the next one?

This sounds like it could be a whole new feature. Could you make an issue for this with a further explanation?

Milozap commented 1 year ago

This Pr checks if growth session is from yesterday and then hides their topics right? Do you think it would be better to add a filter for full growth sessions (for example 4 out of 4) in this PR or the next one?

This sounds like it could be a whole new feature. Could you make an issue for this with a further explanation?

Yea I think I wasn't clear in this issue but that's what I meant by It would be great to have a way to filter out growth sessions that are full. I meant a checkbox or some other UI element that would allow users to hide full growth sessions if they are looking only for ones they can join.

Does this description work better? I don't want to block your work because it looks good thought so I will approve once the branch is updated to new base.

FRFlor commented 1 year ago

The branch was out of date because I merged a couple of other PRs since then. I've updated his branch to the latest master now.

I would love to talk more about this PR over here, I personally would prefer to be able to see the description of past growth sessions.

In regards to adding a checkbox to filter out Growth sessions that don't have spots available, that sounds like a great idea.

ANDREYDEN commented 1 year ago

@FRFlor Does this call for a settings page? If different users prefer different views of the GS list, should we allow them to configure their preferences?

FRFlor commented 1 year ago

@FRFlor Does this call for a settings page? If different users prefer different views of the GS list, should we allow them to configure their preferences?

I think so. Personal preferences fit well in this case.

We could include things like:

Display name
Theme: Dark/Light
Preferred visibility: All / Public Only / Private Only
Display description of past sessions: On / Off

ANDREYDEN commented 1 year ago

@FRFlor, since this requires more work, should we close this PR and implement the preferences page/dialog first?

FRFlor commented 1 year ago

@FRFlor, since this requires more work, should we close this PR and implement the preferences page/dialog first?

Yeah, I agree.

Are you okay with that @IthJ ?

We could work on getting a preferences page live as soon as possible.

IthJ commented 1 year ago

@FRFlor, since this requires more work, should we close this PR and implement the preferences page/dialog first?

Yeah, I agree.

Are you okay with that @IthJ ?

We could work on getting a preferences page live as soon as possible.

Sure, let's close this and add it to the preferences page.