search

velikanov / SwiftPasscodeLock

An iOS passcode lock with TouchID authentication written in Swift.
MIT License
199 stars 52 forks source link

Allow to setup windowLevel #25

Open asfdfdfd opened 8 years ago

asfdfdfd commented 8 years ago

Because it may conflict with other libraries. For example https://github.com/terryworona/TWMessageBarManager

ziogaschr commented 8 years ago

This is a good idea indeed. Can you make a PR on this one?

asfdfdfd commented 8 years ago

I could try. But i'm not sure what is the best implementation from architectural point of view. Probably new protocol for such behaviour or maybe just parameter in PasscodeLockConfigurationType.

ziogaschr commented 8 years ago

I would think it fits nice in PasscodeLockConfigurationType :)

ziogaschr commented 8 years ago

What do you think of PR #28. Adding it in PasscodeLockConfigurationType will not be backward compatible :)

asfdfdfd commented 8 years ago
  1. I think that passcodeLockWindow windowLevel is not enough. Other libraries could change main windowLevel too. And to be in sync it may be better to setup main windowLevel, passcodeLockWindow behind windowLevel and passcodeLockWindow at the front windowLevel;
  2. To maintain backward compatibility default protocol extension could be made. Or new configuration type probably. Not sure which is better.
ziogaschr commented 8 years ago

I am not so familiar with regards using many windows. Can you make a PR please with what you think as better?

Thanks a lot for trying to make this library better :)

asfdfdfd commented 8 years ago

Yes, i'll do. Just have not time for it right now. Will try on next week.

ziogaschr commented 8 years ago

Thank you

Sent from my iPhone

On 13 ???? 2016, at 01:03, asfdfdfd notifications@github.com<mailto:notifications@github.com> wrote:

Yes, i'll do. Just have not time for it right now. Will try on next week.

You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/velikanov/SwiftPasscodeLock/issues/25#issuecomment-225463216, or mute the threadhttps://github.com/notifications/unsubscribe/AAw_jKMRqxK7OiSkiTA4GEF_vOl6KFdbks5qLIIRgaJpZM4IvS00.

asfdfdfd commented 8 years ago

Here it is: #37