Fix small typo - Githubissues

velikanov / SwiftPasscodeLock

An iOS passcode lock with TouchID authentication written in Swift.

MIT License

199 stars 52 forks source link

Fix small typo #31

Open jrmsklar opened 8 years ago

jrmsklar commented 8 years ago

This PR fixes a small typo in the word "incorrect".

ziogaschr commented 8 years ago

Thanks for the help @jrmsklar.

This PR is partially handled in #27.

Current PR is not backward compatible as it also changes maximumInccorectPasscodeAttempts which is a public property and it might brake current apps using this lib.

jrmsklar commented 8 years ago

@ziogaschr gotchya 👍.

Will maximumInccorectPasscodeAttempts be updated in that other PR? I think it'd be beneficial to correct that even at the expense of developers updating that name when updating the pod.

ziogaschr commented 8 years ago

Will maximumInccorectPasscodeAttempts be updated in that other PR?

no, it won't.

@velikanov has a nice list with such typos #9.

I was thinking that we should wait for the next release, let's see what rest people think.

jrmsklar commented 8 years ago

Sounds good.