venantius / darg

Kill the status meeting -- an abandoned IDoneThis competitor.
1 stars 0 forks source link

GET User endpoint #141

Closed Lagoja closed 10 years ago

Lagoja commented 10 years ago
venantius commented 10 years ago

No tests for new darg.model.users functions.

venantius commented 10 years ago

There's obviously a discussion to be had about the more generic get-X functions; I think I can intuit what you were going for but I'd like to make sure I understand it first. In either case I find the functions really hard to understand right now - I suspect we can put something together that meets the needs we have while being more maintainable in the long run.

venantius commented 10 years ago

Hopefully my comment about the korma.sql.fns ns will help with that fetch function - I realize that using korma.sql.fns directly can feel sort of ugly but I think it's way, way to be preferred over writing our own loop/recur for fetch. It also has the benefit of being very clear as to what it's doing :).

As in many programming things, magic is great, right up until it stops working.

Lagoja commented 10 years ago

Ok, I'm going to revert this tonight and try with the sql.fns directly.

I do think it's kinda ugly, but i'm going to punt until i come up with a more idiomatic solution vs. loop recur.

Lagoja commented 10 years ago

closing this and re-uploading branch with fixes.

New branch will fix all issues here except for moving some of the darg.api.v1 stuff into fixtures/utils. I will address this later. This new branch will also add tests for my new users functions.