vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.33k stars 3.52k forks source link

Text pasted has white background on white #819

Closed jdsimcoe closed 4 years ago

jdsimcoe commented 8 years ago

When I paste any text in to Hyper.app the pasted text shows white background on white:

screen shot 2016-10-07 at 1 38 37 pm

I have no plugins.

flybayer commented 8 years ago

Does this still happen if you temporarily comment out all of your custom configuration and plugins?

dennisroethig commented 8 years ago

fwiw I saw that behaviour too a few times, after trying to replicate it and restarting Hyper multiple times it seems to be fine now ¯(ツ)

iamstarkov commented 8 years ago

have seen this today

jdsimcoe commented 8 years ago

@flybayer I commented everything out and it still happens.

muescha commented 8 years ago

the white on white in nano editor (#838) is without any plugin enabled. a fresh install

timothyis commented 8 years ago

@muescha I can reproduce.

jessemillar commented 8 years ago

I can also reproduce. If I change my foregroundColor to be partially transparent (e.g. 'rgba(255, 255, 255, 0.75)'), I can at least read the highlighted text, but it's far from perfect.

The same bug can be seen when using vim and selecting white text with the v visual selector.

Edit: I'm using zsh as my shell which is interesting considering @LukasMa's report below.

lukasmalkmus commented 8 years ago

I can reproduce on OS X: Hyper + zsh = NOT OK! Hyper + bash = OK! iTerm2 + zsh = OK! iTerm2 + bash = OK! (No modifications/plugins whatsoever!)

nicholasruggeri commented 8 years ago

Fresh install. White on white in nano editor screenshot 2016-10-14 17 42 38

tonybaroneee commented 8 years ago

Fresh install, fish shell, macOS Sierra (10.12)

image

knownasilya commented 8 years ago

Also happens for text like _my test_, which is an issue for markdown files with __my test__ (emphasis). If there was a class on that element, it would be possible to override the style, but no class exists..

jessemillar commented 8 years ago

The lack of classing on highlighted text has been my issue in attempting local mitigation as well...

LeonBlade commented 8 years ago

Fresh install, same problem. I'd rather use vim over nano anyway... but, it also effects pasted text.

chriscraws commented 8 years ago

I ran into this issue using hyper for the first time; both bash and zsh are affected for me.

ipalindromi commented 7 years ago

I am also experiencing this issue after a first time install with zsh on macOS Sierra.

lordgiotto commented 7 years ago

Same issue here with Sierra, hyper 0.8.3 and zsh.

reneruiz commented 7 years ago

Also affected. Sierra, hyper 0.8.3., zsh 5.2

harryparkdotio commented 7 years ago

Same issue here, Sierra: 10.12.1. Hyper: 0.8.3 (0.8.3.873). Also using zsh.

svenfinke commented 7 years ago

Same issue here... Sierra 10.12.1 + Hyper: 0.8.3.873 And I am also using zsh, with the agnostic theme. This makes Hyper pretty much unusable for me atm... 😢

4cm4k1 commented 7 years ago

Same issue here.

It’s probably been mentioned before somewhere else, but here’s a temporary workaround until the bug is fixed. Just add the following lines of code in your .hyper.js or by clicking Preferences in the menu bar:

module.exports = {
    config: {
        ...
        // custom css to embed in the terminal window (this comment is in .hyper.js by default)
        // below is temp workaround for nano & copy/paste whiteouts
        termCSS: 'span { background-color: transparent !important; }',
        ...
    }
};

Works for me until it gets fixed. 😀

ppot commented 7 years ago

This doesn't happen to me on resent master

benjaminprojas commented 7 years ago

I just downloaded hyper yesterday for the first time, no plugins, I have this issue when editing the preferences.

jdsimcoe commented 7 years ago

Doesn't happen anymore for me on a recent master build.

ppot commented 7 years ago

@CodeTheory You can mark this solved in resent master!

ppot commented 7 years ago

Fix in #1218

jakeNiemiec commented 6 years ago

This has cropped up again on Hyper+Zsh after the update. The css hack no longer works.

But fear not, you can disable this behavior on the zsh side with unset zle_bracketed_paste. (put this in your .zshrc file: echo 'unset zle_bracketed_paste' >> ~/.zshrc)

lukasmalkmus commented 6 years ago

Same here but with Hyper+fish since the 2.0 release.

txchen commented 6 years ago

Same here with Hyper(2.0) + ZSH. Hope the CSS hack can work again, I don't want to put hack in my .zshrc since I still like the feature.

cacois commented 5 years ago

even with hacking .zshrc, this bug crops up in another place:

image Not sure what the context is here, because its not a paste, but that white bar at the bottom looks like this in iTerm2:

image

jakeNiemiec commented 5 years ago

@timothyis @ppot, please consider reopening this 🙏

mamakawama commented 5 years ago

Same here with Hyper(2.0) + ZSH.

loftusa commented 5 years ago

Having the same problem. Even uninstalled ZSH, bug persists. @timothyis @ppot seconding @jakeNiemiec, please consider reopening

hugofloss commented 5 years ago

Same problem here with a fresh install of Hyper 2.0.0

srchulo commented 5 years ago

I also see this in 2.1.0 stable. Running zsh.

srchulo commented 5 years ago

I see it in vim when I highlight:

image

bkjoel commented 5 years ago
image

I got it when searching for "color" inside man ls using hyper and zsh

lotap commented 5 years ago

I also am experiencing this issue when pasting and when create-a-react-app finds a linting error. I was able to "solve" the issue by removing the hyper-transparent plugin. I also noticed when I set opacity to 1 with that plugin installed, everything worked as expected.

OSX 10.14.2 ZSH

wbsmolen commented 5 years ago

Seeing this on Mojave, hyper 2.1.1. Not running zsh. Not using the hyper-transparent plugin. Please consider reopening this.

reneroth commented 5 years ago

Reopen please, Hyper 2.1.2 with zsh

only happening when using a backgroundColor with opacity

wbsmolen commented 5 years ago

@ppot would you consider reopening this? There appear to outstanding problems. I don't want to spam github with duplicate issues

Edit: Thank you @ ppot

jakeNiemiec commented 5 years ago

@chabou @juancampa @rauchg also seem active here and would probably have rights to reopen this issue. I agree with @wbsmolen, there is a lot of good info here that would be lost with a new issue.

Sorry for the ping, I wouldn't be such a pest if this bug wasn't such a constant obstacle. I would've made a PR myself if I had even the slightest idea how to fix this 🤔...I just wish my terminal didn't look like a redacted government document.

Edit: 🎉 Thanks @ ppot

ohgree commented 5 years ago

can reproduce same issue here, with hyper-material-theme plugin, if backgroundOpacity is 1, the problem is not recurring whereas below 1, nano shows white-on-white texts and etc.

lmcl90 commented 5 years ago

met this on mojave 10.14.3 and hyper 2.1.2 with hyper-search (0.1.1) and verminal (1.4.3). After set opacity of backgroundColor by 1 or uninstall verminal, everything works fine.

bkjoel commented 5 years ago

Sorry to be such a nag but is there any updates on this issue? anyone maybe had success with quick & dirty fixes other than switching Hyper?

linonetwo commented 5 years ago

@bkjoel You can switch zsh feature off by adding unset zle_bracketed_paste to .zshrc

ohgree commented 5 years ago

@linonetwo It is actually not only about the pasting thing, but every white-backgrounded text, such as nano menus, less (END) text, are all affected by this bug

linonetwo commented 5 years ago

An upstream bug here needs help https://github.com/xtermjs/xterm.js/issues/1898

reneroth commented 5 years ago

for me it's fixed in the newly released v3.0.0

linonetwo commented 5 years ago

I'm excited about the release, but for me, this issue is not fixed. https://github.com/robbyrussell/oh-my-zsh/issues/7832

jakeNiemiec commented 5 years ago

image

It is still present on v3.0.0 for me, here is a visual for reference.