vercel / hyper

A terminal built on web technologies
https://hyper.is
MIT License
43.33k stars 3.52k forks source link

Text pasted has white background on white #819

Closed jdsimcoe closed 4 years ago

jdsimcoe commented 8 years ago

When I paste any text in to Hyper.app the pasted text shows white background on white:

screen shot 2016-10-07 at 1 38 37 pm

I have no plugins.

ohgree commented 5 years ago

Not fixed for me either. On hyper 3.0.0

gvidon commented 5 years ago

Still reproducible on hyper 3.0.0-canary.10 with fish.

DEfusion commented 5 years ago

Getting this on 3.0.2 stable with zsh, the workaround for zsh by @jakeNiemiec works for me at the moment.

mazyvan commented 5 years ago

this issue is also happening on tabs with zsh

isanimu commented 5 years ago

Inside the .hyper.js config, If the backgroundColor was set to not using alpha (ex: #000000), it wouldn't trigger the problem.

Sets the backgroundColor to any color with alpha (ex: rgba(0, 0, 0, 0.8)) WILL trigger the problem if the renderer was not WebGL.

When using plugin that sets the backgroundColor to any color that using alpha will set the renderer to use WebGL instead of Canvas renderer. While setting it inside the config won't, I don't know why.

I've tested it using hyper-material-theme plugin and also tested using dummy local plugin to set the backgroundColor to a color with alpha, it solves the problem because it triggers the renderer to use WebGL.

The only problem when using WebGL renderer is that it will use the dedicated GPU, unless you don't have any problem with that.

@jakeNiemiec unset zle_bracketed_paste to .zshrc works with any renderer and solves the problem for zsh shell.

jakeNiemiec commented 5 years ago

I removed everything alpha/opacity related and now everything works. Thanks @isanimu!

mvllow commented 5 years ago

Unfortunately still having this issue. With a fresh install, highlighted text is somewhat legible (translucent white with white text) but with themes such as hyper-website-theme and hyper-snazzy the text is still white/white. I suppose it could be an issue with the themes as I've only tested a few but either way, without a theme it is still not ideal.

Relaxself commented 4 years ago

It's appear when I use opacity color or plugin.

bet4it commented 4 years ago

@Relaxself Try v3.1.0-canary.4

Relaxself commented 4 years ago

@Relaxself Try v3.1.0-canary.4

OK,I‘ll try. thx

Relaxself commented 4 years ago

@Relaxself Try v3.1.0-canary.4

I used 3.1.0 install and fresh install ,but unfortunately, it appear an error. when first I open hyper,the screen like this: image

then i press any key... oh my image

my System info is: MacOS Catalina ZSH and hyper use default config,no plugin and no change

bet4it commented 4 years ago

@Relaxself This may be another issue?

snappy316 commented 4 years ago

Updating to 3.1.0-canary.4 seems to have fixed it! 🎉

Both the pasted text from the original issue, as well as the bug in Nano as shown in this comment are now fixed!!

(For reference, backgroundColor: "rgba(0, 0, 0, 0.7)" in my config was broken in 3.0.2, but was immediately fixed in the canary version.)

OnTheRicky commented 4 years ago

I have this problem not only when I paste text, but also when there is download bar that "scrolls over" text.

Running Hyper 3.0.2 (stable) + zsh on macOS Catalina Renderers: Canvas (4) Plugins: hyper-search (0.4.0), verminal (1.5.1), hyperline (1.2.0)

Mvrs commented 4 years ago

Can confirm that this problem has been resolved in the latest 3.1.0-canary.4 version :partying_face:

LabhanshAgrawal commented 4 years ago

Based on the last comment, it seems to be fixed. Closing this, Feel free to open a new issue if you face any problems.