search

verifiablesoftware / vsw

Core project of VerifiableSoftware
Apache License 2.0
1 stars 0 forks source link

Revoke reports success but no effect #118

Closed wenjing closed 3 years ago

wenjing commented 3 years ago

I ran vsw verify with quoted parameters. It reported back success, but the credential is not revoked. It should report error instead.

root@d3a9fc3ff50d:/# vsw revoke -reg "3JLMs2LpdbmoGhW45RxDrE:4:3JLMs2LpdbmoGhW45RxDrE:3:CL:3733:default:CL_ACCUM:957edebd-ad8b-499d-8641-c22488b3a8e3" -rev "1" Revoke successfully!

But if I check with verify, the credential has not been revoked.

If I ran with correct format:

root@d3a9fc3ff50d:/# vsw revoke -reg 3JLMs2LpdbmoGhW45RxDrE:4:3JLMs2LpdbmoGhW45RxDrE:3:CL:3733:default:CL_ACCUM:957edebd-ad8b-499d-8641-c22488b3a8e3 -rev 1 Revoke successfully!

This time, it works.

So, when the parameters are in wrong format, it should check and report error and not proceed. I also wonder why it reported success at all?

felixchen1023 commented 3 years ago

have you published the same credential several times? I remember If you publish multiple times for the same credential and revoke one of them, it still can verify successfully.

wenjing commented 3 years ago

No, all DIDs are brand new in my test script so they can never overlap because even if all other fields are identical, the issuer's DIDs are always different.

This bug is ONLY about the quotes "xyz" vs xyz. If I quote them, it does not seem to have any effect. Once I remove the quotes, it works correctly.

wenjing commented 3 years ago

Tested again. the cli seems to take "xyz" in correctly and revoke is effective. Or, it could be the original test error was caused by some other reason. Either way, I'm closing this.