verifiablesoftware / vsw

Core project of VerifiableSoftware
Apache License 2.0
1 stars 0 forks source link

vsw does not work for non-endorsers #91

Closed wenjing closed 3 years ago

wenjing commented 3 years ago

In vsw design, only the issuer (publisher) and holder (repo) need to be an endorser in the ledger to write transactions. Most users are verifiers who do not need to be an endorser because they only read and never write to the ledger. The correct behavior for vsw setup is to allow both options. Becoming an endorser is optional.

To test/reproduce this: during vsw setup steps, do not execute the endorser setting, and continue with the other steps. You can see vsw client shuts down the aca-py agent:

root@fe87592597c8:/# vsw setup -n wallet1 Please enter wallet key: 2021-04-19 21:10:53 vsw.commands.setup INFO /usr/local/lib/python3.6/dist-packages/vsw/commands/setup.py genesis_file: /usr/local/lib/python3.6/dist-packages/vsw/conf/genesis.txt 2021-04-19 21:10:53 vsw.commands.setup INFO /usr/local/lib/python3.6/dist-packages/vsw/commands/setup.py seed:30816a3fd6224b6a95779d01e95f924f root@fe87592597c8:/# Public DID: YbY2E2W2ekxhefJdxJgPVy Verkey: JDo3GfyP5sKYcaf6zUeTYkQzr8zBXXjiZUzd7g18XjzC

root@fe87592597c8:/# Shutting down

wenjing commented 3 years ago

I have raised the priority to this bug since it is the root of several other important issues. The expected behavior at the setup time is as follows:

For verifiers, the setup is done. It can start run verify commands now.

For publishers, the next additional steps are needed:

wenjing commented 3 years ago

Postponing it as a future enhancement. This will require a protocol exchange between client and repo.