Update case gather with additional information

[AriHrannar]

Status

Ready

Description

Gather some additional data from althingi.is and add that to cases. Like the link to althingi.is, the case status, who put it forward and what subjects are related to it.

Added status, althingi_status. althingi_link and case_creators

Current case object

{
        "id": 1,
        "name": "fjárlög 2017",
        "number": 1,
        "case_type": "Frumvarp til laga",
        "althingi_status": "Samþykkt sem lög frá Alþingi.",
        "parliament_session": {
            "session_number": 146,
            "parliament": {
                "name": "Test-Parliament",
                "id": 1
            },
            "name": "Test-Parliament-Session",
            "created": "2017-04-25T17:41:28Z",
            "modified": "2017-04-25T17:41:28Z"
        },
        "created": "2017-08-18T23:19:32.077600Z",
        "modified": "2017-08-18T23:19:32.077683Z",
        "althingi_link": "http://www.althingi.is/dba-bin/ferill.pl?ltg=146&mnr=1",
        "case_creators": [
            {
                "parliament_member": {
                    "name": "Haraldur Benediktsson",
                    "id": 25,
                    "initials": "HarB",
                    "districtNumber": 1,
                    "party": {
                        "name": "Sjálfstæðisflokkur",
                        "id": 1,
                        "website": "http://xd.is/",
                        "created": "2017-04-25T17:41:28Z",
                        "modified": "2017-04-25T17:41:28Z"
                    },
                    "district": {
                        "name": "Norðvesturkjördæmi",
                        "id": 6,
                        "abbreviation": "Norðvest.",
                        "politicians": [
                            {
                                "name": "Elsa Lára Arnardóttir",
                                "id": 16,
                                "initials": "ELA",
                                "party": {
                                    "name": "Framsóknarflokkurinn",
                                    "id": 2,
                                    "website": "https://framsokn.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Eva Pandora Baldursdóttir",
                                "id": 17,
                                "initials": "EPB",
                                "party": {
                                    "name": "Píratar",
                                    "id": 5,
                                    "website": "https://piratar.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Guðjón S. Brjánsson",
                                "id": 19,
                                "initials": "GBr",
                                "party": {
                                    "name": "Samfylkingin",
                                    "id": 6,
                                    "website": "http://xs.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Gunnar Bragi Sveinsson",
                                "id": 22,
                                "initials": "GBS",
                                "party": {
                                    "name": "Framsóknarflokkurinn",
                                    "id": 2,
                                    "website": "https://framsokn.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Haraldur Benediktsson",
                                "id": 25,
                                "initials": "HarB",
                                "party": {
                                    "name": "Sjálfstæðisflokkur",
                                    "id": 1,
                                    "website": "http://xd.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Lilja Rafney Magnúsdóttir",
                                "id": 35,
                                "initials": "LRM",
                                "party": {
                                    "name": "Vinstri Hreyfingin - Grænt Framboð",
                                    "id": 3,
                                    "website": "http://vg.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Teitur Björn Einarsson",
                                "id": 53,
                                "initials": "TBE",
                                "party": {
                                    "name": "Sjálfstæðisflokkur",
                                    "id": 1,
                                    "website": "http://xd.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            },
                            {
                                "name": "Þórdís Kolbrun R. Gylfadóttir",
                                "id": 61,
                                "initials": "ÞórdG",
                                "party": {
                                    "name": "Sjálfstæðisflokkur",
                                    "id": 1,
                                    "website": "http://xd.is/",
                                    "created": "2017-04-25T17:41:28Z",
                                    "modified": "2017-04-25T17:41:28Z"
                                },
                                "promises": []
                            }
                        ],
                        "created": "2017-04-25T17:41:28Z",
                        "modified": "2017-04-25T17:41:28Z"
                    }
                }
            }
        ]
    },

(bit awkward with the current nested serialization and even crashes chrome for me :) )

Todos

• [x] Structure code a bit better
• [x] Dont use static parliament session id, use latest (or latest two just in case)
• [x] Do we care about subject hierarchy?
• [x] Remove Bills model?
• [x] Should we have questions? (I think thats cases with type "q")
• [x] Tests
• [x] Why does it sometimes fail silently!!!

[Ragnar-H]

I was too eager to approve the PR.

Some tests are failing :(

..F..........................
======================================================================
FAIL: test_get_case_creators (case_gather.xml_parser_test.GetCaseCreatorNames)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/code/src/case_gather/xml_parser_test.py", line 28, in test_get_case_creators
self.assertEqual(expected, case_creators)
AssertionError: Lists differ: ['John', 'James', 'Jonathan'] != []
First list contains 3 additional elements.
First extra element 0:
'John'
- ['John', 'James', 'Jonathan']
+ []