veritus / veritus-backend

1 stars 0 forks source link

Feature/politicians get #50

Closed Ragnar-H closed 7 years ago

Ragnar-H commented 7 years ago

Requires a fresh DB. Make sure you delete your current one💣

Status

Ready

Description

Parliamentmembers now inherit from the Politician model. The reasoning being that Politicians don't need to be Parliament Members.

Testing

Make sure initial_data.json is loaded. Call GET localhost:8000/api/v1/politicians/

Ragnar-H commented 7 years ago

@AriHrannar I can't see why Travis is failing https://travis-ci.org/veritus/veritus-backend/builds/251503665?utm_source=github_status&utm_medium=notification

halp!

AriHrannar commented 7 years ago

Seems to be because of linting

$ pylint */*.py
************* Module parliament.models
C: 15, 0: Final newline missing (missing-final-newline)
************* Module politicians.admin
W:  1, 0: Unused admin imported from django.contrib (unused-import)
************* Module politicians.serializers
C: 21, 0: Trailing newlines (trailing-newlines)
C:  3, 0: external import "from party.serializers import PartySerializerRead" comes before "from .models import Politician" (wrong-import-order)
C:  4, 0: external import "from district.serializers import DistrictSerializer" comes before "from .models import Politician" (wrong-import-order)
C:  5, 0: external import "from promises.serializers import PromiseSerializerRead" comes before "from .models import Politician" (wrong-import-order)
************* Module politicians.tests
W:  1, 0: Unused TestCase imported from django.test (unused-import)
************* Module politicians.views
C: 16, 0: Trailing newlines (trailing-newlines)
W:  1, 0: Unused status imported from rest_framework (unused-import)
C:  6, 0: external import "from rest_framework.permissions import IsAuthenticatedOrReadOnly" comes before "from .models import Politician" (wrong-import-order)
coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling c994ac14c15dd2424e72148204698e4ac59106b1 on feature/politicians-get into on master.