search

veritus / veritus-backend

1 stars 0 forks source link

Introducing sentry, logging to console in dev and production settings #58

Closed AriHrannar closed 7 years ago

AriHrannar commented 7 years ago

Status

Ready

Description

  1. Production integration with Sentry
  2. Most loggers now log in the console
  3. Since cron runs in a separate daemon, it cant log to the console. Therefore we still log to files there, but for development purposes we mount them into a /logs directory in the root of the project.
  4. Local and production settings
  5. Runs well locally with docker compose AND deployable via docker cloud!
AriHrannar commented 7 years ago

@skabbi how much experience do you have with Docker, Docker compose and https://cloud.docker.com

skabbi commented 7 years ago

@AriHrannar Very limited, just know the basics. Why do you ask?

AriHrannar commented 7 years ago

@skabbi mostly wondering how much that interests you :) I can at least invite you to the docker cloud organization we have (just send me your email on Facebook or something)

About Sentry, it seems like the free version is limited to only 1 user in the cloud right now. Options:

  1. Setup on-premise, but that requires some coding (need to generate a key and put it as an environment variable)
  2. Share my Account (think we should do this for now at least)
Ragnar-H commented 7 years ago

@AriHrannar the tests seem to be breaking, is that because there is a lot of infrastructure that's changed?

AriHrannar commented 7 years ago

Maybe the docker-compose.test.yml isnt 100% in sync with the new changes. Ill check this out either today or tomorrow

AriHrannar commented 7 years ago

@Ragnar-H is fixed now :)

Ragnar-H commented 7 years ago

@Ragnar-H is fixed now :)

I'm fixed now? That's great 😁

Ragnar-H commented 7 years ago

About Sentry, it seems like the free version is limited to only 1 user in the cloud right now. Options: Setup on-premise, but that requires some coding (need to generate a key and put it as an environment variable) Share my Account (think we should do this for now at least)

How about creating a Veritus account? Is that an option?

AriHrannar commented 7 years ago

I have a "Veritus" organization on Sentry but it seems its limited to 1 "person account" in the free tier. As in, one email. I guess we could have a Veritus account, but I would prefer to get all emails to my email account to follow the error reporting :)

I think that is fine for now, if you guys ever need access, ill send you the password

AriHrannar commented 7 years ago

@Ragnar-H did you maybe review an old version of the files? All your comments appear to be out of date

Ragnar-H commented 7 years ago

@Ragnar-H did you maybe review an old version of the files? All your comments appear to be out of date

I review commit-by-commit. Once I started doing this, I got a much deeper understanding of what pull requests are about :)

This is one of the reasons I love rebasing master, and using Squash before merging ❤️