search

verlab / hero_common

This project contributes to an open source ROS-based framework for swarm robotics. We propose an low cost, high availability swarm system that could be printed and assembled multiple times without special knowledge or hardware skills.
https://verlab.github.io/hero_common/
60 stars 16 forks source link

Fix the tf part of the launch file generation script #21

Closed Suptree closed 1 year ago

Suptree commented 1 year ago

Summary

This PR addresses an issue with the TF description in the launch file generated by the wizard screen initiated by the roslaunch hero_gazebo gazebo_wizard.launch command.

Background

As reported in Issue #20 , the current TF description causes an error when attempting to display in rviz.

Changes Made

I have made modifications to wizard_script.py.

Impact

The TF relationships have been corrected as follows:

fix_tf

Due to this correction, HeRo is now successfully displayed in rviz.

Testing

The updated code has been tested in the following environments:

ROS Noetic Gazebo 11 rviz 1.14.20

Additional Notes

It was determined that the issue is likely due to rule changes in tf-prefix between ROS Noetic and Melodic distros.

I'm not very experienced with submitting pull requests, so please feel free to point out any discrepancies or issues.

Thank you for your consideration.

rezeck commented 1 year ago

Hello @Suptree, Great work on the detailed pull request! Everything looks good to me. Thank you for your contribution!