search

vert-x3 / vertx-rx

Reactive Extensions for Vert.x
Apache License 2.0
147 stars 72 forks source link

Fixes #200 ReadStreamSubscriber does not properly handle errors deliv… #266

Closed flukschander closed 3 years ago

flukschander commented 3 years ago

Motivation:

Currently in ReadStreamSubscriber#asReadStream the given Observable/Flowable is directly subscribed to which leads to an IllegalStateException should it only deliver an exception or is empty. This change will subscribe to the give Observable/Flowable only on a call to ReadStreamSubscriber#handler which also conforms better to the ReadStream specification as it should only start to deliver elements as a handler is set.

vietj commented 3 years ago

we need to have tests for this

flukschander commented 3 years ago

we need to have tests for this

@vietj Sorry for that. Added a few tests

flukschander commented 3 years ago

@vietj did you have time to review yet?

vietj commented 3 years ago

not yet, but it's on my todo list :-)

flukschander commented 3 years ago

fixed as requested

flukschander commented 3 years ago

done

vietj commented 3 years ago

can you provide a backport PR to 4.1 branch @flukschander ?