search

vert-x3 / vertx-rx

Reactive Extensions for Vert.x
Apache License 2.0
147 stars 73 forks source link

Added Vert.x Oracle Client #278

Closed tsegismont closed 2 years ago

tsegismont commented 2 years ago

Oracle Client Rx bindings are not present in the stack yet

tsegismont commented 2 years ago

The build fails because, when using JDK8, the classes of the Reactive Oracle Client cannot be read. Indeed, the module is built with JDK11:

            <configuration>
              <toolchains>
                <jdk>
                  <version>11</version>
                </jdk>
              </toolchains>
            </configuration>

@vietj I know the Oracle JDBC driver requires Java 11+ at runtime but have we tried to build the module with JDK8 and run tests only when JDK11+ is used?

That would help solve this stack integration issue as well as the Kotlin one: https://github.com/vert-x3/vertx-lang-kotlin/pull/215

vietj commented 2 years ago

that is not possible because Oracle jar is compiled with bytecode of Java 11+

vietj commented 2 years ago

toolchain requires a specific configuration in the .m2 file and install an extra JDK, we could try to support it in this GitHub action.

tsegismont commented 2 years ago

Thanks for tip. I'll give it a try when we work on 4.3

vietj commented 2 years ago

ping @tsegismont

tsegismont commented 2 years ago

@vietj PTAL

The second commit message gives some details about the changes