search

vert-x3 / vertx-rx

Reactive Extensions for Vert.x
Apache License 2.0
145 stars 72 forks source link

feat: instrument vertx-web-openapi-router #298

Closed pk-work closed 9 months ago

pk-work commented 9 months ago

Add rx2 and rx3 support for vertx-web-openapi-router

tsegismont commented 9 months ago

There's a build issue related to this change

pk-work commented 9 months ago

Yes, because this [1] interface is not public. But this is intended. Maybe we can remove the @VertxGen annotation from the interface?

[1] https://github.com/eclipse-vertx/vertx-openapi/blob/15772194a1c95142ae1b818900f9d2938cc9e1ef/src/main/java/io/vertx/openapi/validation/Parameter.java#L23

tsegismont commented 9 months ago

If a type is not part of the public API, I don't believe it should be annotated with @VertxGen

Le ven. 20 oct. 2023 à 16:14, Pascal @.***> a écrit :

Yes, because this [1] interface is not public. But this is intended. Maybe we can remove the @VertxGen annotation from the interface?

[1] https://github.com/eclipse-vertx/vertx-openapi/blob/15772194a1c95142ae1b818900f9d2938cc9e1ef/src/main/java/io/vertx/openapi/validation/Parameter.java#L23

— Reply to this email directly, view it on GitHub https://github.com/vert-x3/vertx-rx/pull/298#issuecomment-1772819489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALOLNS4WNPLOHCSVSB6E43YAKBLHAVCNFSM6AAAAAA6I5345GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZSHAYTSNBYHE . You are receiving this because your review was requested.Message ID: @.***>