vertica / vertica-grafana-datasource

Official Vertica datasource plugin for Grafana.
https://grafana.com/grafana/plugins/vertica-grafana-datasource/
Apache License 2.0
3 stars 9 forks source link

Does not work on Apple M2 Pro #44

Closed Zeevbd closed 8 months ago

Zeevbd commented 11 months ago

Hi, i have raised a ticket on a vertica plugin compatibility for M2 Apple Chipset. the suggestion from tech support to raise an issue in the GitHub Rep:

have tried the solution given for the M1 Apple Chipset but it seems to not work: https://github.com/vertica/vertica-grafana-datasource/issues/41

################################################################# Response from : Grafana Tech Support suggested to open an issue under GitHub repo ################################################################# "The error seems to be related to the plugin compatibility, and it is recommended to raise the issue in the GitHub repo and please let them know you already tried the suggestion for M1." (Jay T. Support Engineer Grafana Labs)

please assist

tanvipise commented 11 months ago

Hi, Can you please explain the steps you followed to set up the plugin? I am assuming it should be something related to the installation that went wrong. Let me know, I can try to reproduce it.

Zeevbd commented 11 months ago

Certainly,

So i tried building up the plugin, but ended up with no success

steps i used: Used the Command: git clone https://github.com/vertica/vertica-grafana-datasource yarn is installed : yarn run v1.22.19

warning package.json: "dependencies" has dependency "react-autosuggest" with range "^10.1.0" that collides with a dependency in "devDependencies" of the same name with version "^9.4.3"

conflict on the versions under packages.json

so i have aligned the autosuggest on the file:

"@types/react-autosuggest": "^10.1.6",

"ts-jest": "26.4.4",

"ts-loader": "8.0.4",

"tslib": "^2.2.0",

"typescript": "4.1.2"

}, "resolutions": { "rxjs": "6.6.3" }, "engines": { "node": ">=14" }, "dependencies": { "@emotion/css": "^11.10.5", "@types/react-autosuggest": "^10.1.6", "@types/react-virtualized-auto-sizer": "^1.0.1", "ace-builds": "^1.15.2", "brace": "^0.11.1", "grafana-data": "^2.0.1", "react-ace": "^10.1.0", "react-autosuggest": "^10.1.0", "react-awesome-query-builder": "^5.4.1", "react-monaco-editor": "^0.51.0", "react-use": "^17.4.0", "react-virtualized-auto-sizer": "^1.0.7", "yarn": "^1.22.19" }

after aligning manually the Version expectations results then showed the following:

$ grafana-toolkit plugin:build No longer supported. Use grafana create-plugin https://github.com/grafana/plugin-tools/tree/main/packages/create-plugin

error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

hope this elaborates the process

tanvipise commented 11 months ago

Thanks for the info. I am trying to reproduce this and will update you soon. All the tests that we have done till now are based on Linux and Windows environments.

Have you tried installing the plugin from Grafana interface itself instead of building the plugin? Does the Grafana plugins list show the plugin in there? image

Usually building the plugin will need a complete environment setup that includes Go, Mage, etc as mentioned in the Readme.

Maybe try uninstalling and deleting the plugin folder through the grafana-cli command: grafana-cli plugins remove vertica-grafana-datasource

Another approach is to verify the plugin id. It should specify the exact name - vertica-grafana-datasource

Zeevbd commented 11 months ago

Thanks for the update, i did both ways:

logger=secrets t=2023-06-24T23:43:14.268113+03:00 level=info msg="Envelope encryption state" enabled=true currentprovider=secretKey.v1 logger=local.finder t=2023-06-24T23:43:14.326493+03:00 level=warn msg="Skipping finding plugins as directory does not exist" path=/opt/homebrew/opt/grafana/share/grafana/plugins-bundled logger=plugin.loader t=2023-06-24T23:43:14.379145+03:00 level=info msg="Plugin registered" pluginID=vertica-grafana-datasource logger=plugin.loader t=2023-06-24T23:43:14.380466+03:00 level=error msg="Could not start plugin" pluginId=vertica-grafana-datasource err="fork/exec /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource/gpx_vertica-grafana-plugin_darwin_arm64: no such file or directory"

a note worth mentioning: have installed grafana via brew

restarted the grafana service: brew services restart grafana

Thanks. Ze'ev

tanvipise commented 11 months ago

Hi,

It worked for me with no issues after reproducing from your steps provided. The plugin path in your case is path=/opt/homebrew/opt/grafana/share/grafana/plugins-bundled whereas in my system it shows /usr/local/var/lib/grafana/plugins/vertica-grafana-datasource

Can you try to check the config file - grafana.ini file to see if the plugin's path has been changed? You’ll find the config file in /usr/local/etc/grafana/grafana.ini. It should be commented (with the semicolon, ;), in which case the default path will be used. You can also try uncommenting the line and set the directory to one that you decide.

Zeevbd commented 11 months ago

Thanks for the comments, i tried your suggestions:

so the grafana.ini file that is loaded by grafana resides under: /opt/homebrew/etc/grafana/grafana.ini

(took out the semicolon ;)

Directory where grafana will automatically scan and look for plugins

plugins = /opt/homebrew/var/lib/grafana/plugins

restarted the service:

❯ brew services restart grafana Stopping grafana... (might take a while) ==> Successfully stopped grafana (label: homebrew.mxcl.grafana) ==> Successfully started grafana (label: homebrew.mxcl.grafana) /opt/homebrew/var/plugins stable ❯

opened the admin/settings: to see that plugins folder is updated:

image

vertica plugins location directory: ❯ sudo find / -name vertica-grafana-datasource -print 2>/dev/null /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource

log file showed after the restart: logger=plugin.loader t=2023-07-18T09:07:38.26076+03:00 level=info msg="Plugin registered" pluginID=vertica-grafana-datasource logger=plugin.loader t=2023-07-18T09:07:38.263912+03:00 level=error msg="Could not start plugin" pluginId=vertica-grafana-datasource err="fork/exec /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource/gpx_vertica-grafana-plugin_darwin_arm64: no such file or directory"

as can see, directory is not empty:

❯ pwd /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource ❯ ls -lrt total 125128 -rw-r--r--@ 1 zeev.bd admin 3007 Jul 18 07:46 MANIFEST.txt -rw-r--r--@ 1 zeev.bd admin 1733 Jul 18 07:46 plugin.json -rwxr-xr-x@ 1 zeev.bd admin 11796480 Jul 18 07:46 gpx_vertica-grafana-plugin_linux_arm64 -rwxr-xr-x@ 1 zeev.bd admin 12378624 Jul 18 07:46 gpx_vertica-grafana-plugin_windows_amd64.exe -rw-r--r--@ 1 zeev.bd admin 11357 Jul 18 07:46 LICENSE -rw-r--r--@ 1 zeev.bd admin 541886 Jul 18 07:46 module.js -rwxr-xr-x@ 1 zeev.bd admin 13230752 Jul 18 07:46 gpx_vertica-grafana-plugin_darwin_amd64 drwxr-xr-x@ 13 zeev.bd admin 416 Jul 18 07:46 img -rwxr-xr-x@ 1 zeev.bd admin 12374016 Jul 18 07:46 gpx_vertica-grafana-plugin_linux_amd64 -rw-r--r--@ 1 zeev.bd admin 1828149 Jul 18 07:46 module.js.map -rwxr-xr-x@ 1 zeev.bd admin 11862016 Jul 18 07:46 gpx_vertica-grafana-plugin_linux_arm -rw-r--r--@ 1 zeev.bd admin 13142 Jul 18 07:46 README.md -rw-r--r--@ 1 zeev.bd admin 2510 Jul 18 07:46 module.js.LICENSE.txt

not sure what is missing or not working for me...

Zeevbd commented 11 months ago

one more thing to add: have installed another plugin named CSV

image

Restarted the Grafana Service:

the log does not write any failure with the CSV plugin

cat /opt/homebrew/var/log/grafana-stdout.log

logger=plugin.loader t=2023-07-18T12:40:26.106968+03:00 level=info msg="Plugin registered" pluginID=marcusolsson-csv-datasource logger=plugin.loader t=2023-07-18T12:40:26.124549+03:00 level=info msg="Plugin registered" pluginID=vertica-grafana-datasource logger=plugin.loader t=2023-07-18T12:40:26.12604+03:00 level=error msg="Could not start plugin" pluginId=vertica-grafana-datasource err="fork/exec /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource/gpx_vertica-grafana-plugin_darwin_arm64: no such file or directory"

both plugin directories reside under same folder:

❯ pwd /opt/homebrew/var/lib/grafana/plugins ❯ ls -lrt total 0 drwxr-xr-x@ 15 zeev.bd admin 480 Jul 18 07:46 vertica-grafana-datasource drwxr-xr-x@ 13 zeev.bd admin 416 Jul 18 12:29 marcusolsson-csv-datasource

seems the plugin path is correctly defined HOWEVER, i have no idea why Grafana would not find the file nor directory. of the vertica plugin ..

Please asist Ze'ev

Zeevbd commented 11 months ago

o.k seems like a missing file under the plugin directory: as the grafana server is looking for the file: gpx_vertica-grafana-plugin_darwin_arm64

while directory does not contain arm64 file but: gpx_vertica-grafana-plugin_darwin_amd64

so the Apple M2 looks for the arm64 file that is not present under the plugin directory...

seems that an arm64 compilation file is needed to overcome the problem

tanvipise commented 11 months ago

The distribution list is generated using the Grafana toolkit and published during the plugin release. We don't change the manifest as the toolkit is used to build the package of the plugin.

Did you try installing the plugin through the interface once again after you changed the grafana.ini file and the directory paths? Also, don't forget to restart the service.

I am trying to get some more details on this as well.

Zeevbd commented 11 months ago

i did install the plugin through the interface after changing the grafana.ini... to my opinion the main reason for the failure is that Grafana plugin looks for a file that does not exist in the plugin folder:

Grafana looks for: gpx_vertica-grafana-plugin_darwin_arm64 that does not exist and that is the main cause for the failure.

what is the entity responsible of creating the files under plugin folder? as can see down below the file: gpx_vertica-grafana-plugin_darwin_arm64 does not exist

❯ pwd /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource ❯ ls -lrt total 125128 -rw-r--r--@ 1 zeev.bd admin 3007 Jul 18 07:46 MANIFEST.txt -rw-r--r--@ 1 zeev.bd admin 1733 Jul 18 07:46 plugin.json -rwxr-xr-x@ 1 zeev.bd admin 11796480 Jul 18 07:46 gpx_vertica-grafana-plugin_linux_arm64 -rwxr-xr-x@ 1 zeev.bd admin 12378624 Jul 18 07:46 gpx_vertica-grafana-plugin_windows_amd64.exe -rw-r--r--@ 1 zeev.bd admin 11357 Jul 18 07:46 LICENSE -rw-r--r--@ 1 zeev.bd admin 541886 Jul 18 07:46 module.js -rwxr-xr-x@ 1 zeev.bd admin 13230752 Jul 18 07:46 gpx_vertica-grafana-plugin_darwin_amd64 drwxr-xr-x@ 13 zeev.bd admin 416 Jul 18 07:46 img -rwxr-xr-x@ 1 zeev.bd admin 12374016 Jul 18 07:46 gpx_vertica-grafana-plugin_linux_amd64 -rw-r--r--@ 1 zeev.bd admin 1828149 Jul 18 07:46 module.js.map -rwxr-xr-x@ 1 zeev.bd admin 11862016 Jul 18 07:46 gpx_vertica-grafana-plugin_linux_arm -rw-r--r--@ 1 zeev.bd admin 13142 Jul 18 07:46 README.md -rw-r--r--@ 1 zeev.bd admin 2510 Jul 18 07:46 module.js.LICENSE.txt

tanvipise commented 11 months ago

I am working with the Grafana plugin team to resolve this issue as the arm64 file was not generated by the Grafana toolkit. Will let you know about the update soon.

Zeevbd commented 11 months ago

perfect !!! thank you very much for the help

tanvipise commented 11 months ago

Hi,

While reviewing the documentation, I found that the 'nvm' only supports arm packages after v16 and our plugin is built using v14.17.6. See below: For Macs with the M1 chip, node started offering arm64 arch Darwin packages since v16.0.0 and experimental arm64 support when compiling from source since v14.17.0. If you are facing issues installing node using nvm, you may want to update to one of those versions or later. nvm install and update

Grafana will no longer support the plugin built using the toolkit anymore. I am currently working on the migration from the toolkit. I will be updating the plugin with the latest updates soon and will include the arm64 distribution file for MacOS. Until then, I would advise you to upgrade your environment with 'nvm v>16'.

Zeevbd commented 11 months ago

thanks, so i did install the nvm:

image

the nvm installation added a new file: node-v16.20.1-darwin-arm64.tar.xz

image

i have extracted the directory: but i am not sure how to compile it to the missing plugin: _gpx_vertica-grafana-plugin_darwinarm64

image

any way to move forward on my side? or will it be for the best to wait for your updated plugin that will include the arm64 distribution?

Thanks for you great support. Ze'ev

tanvipise commented 11 months ago

You will have to build the plugin in your environment. The Grafana team forwarded this link, you can give it a try. If not, you can wait for an updated version as we have this in our pipeline.

Thanks, Tanvi

Zeevbd commented 10 months ago

Hi Tanvi, had some questions to the Grafana Tech support asking them for the solution estimation and got the answer below:

can you kindly estimate how long will it take for the plugin to be built?

################################################ ################################################

Hi Ze'ev, I can see the plugin author is discussing this with my plugin team in a separate ticket. It isn't issue with Grafana but rather the plugin needed to comply with our build process. I believe it will take some time but it is best to reach out to the Plugin Author to check with them on the plugin build.

-=-=-=-=-=-=-=-=-=-=-=-=- Jay T. Support Engineer Grafana Labs Need more help? Check out our docs page or visit our community forum: https://grafana.com/docs/ https://community.grafana.com/ -=-=-=-=-=-=-=-=-=-=-=-=-

######################################################## ########################################################

tanvipise commented 10 months ago

Hi, Thanks for the update. We are in sync with the Grafana team for this. Will keep you posted!

asimpson commented 10 months ago

:wave: Hi @Zeevbd I looked into this and I think I understand how to get over this error. Since building the plugin locally you'll need to build the frontend (which you did via yarn) and the backend.

The error message in question gpx_vertica-grafana-plugin_darwin_arm64: no such file or directory is referring the plugin's Go binary. You can build this binary by running mage from the root of the plugin directory (which you mentioned is /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource). mage should produce a binary file called gpx_vertica-grafana-plugin_darwin_arm64 which should get rid of the error message you're seeing.

Let me know if that works! 🤞

Zeevbd commented 10 months ago

Hi @asimpson, thanks for chiming in. looked into your suggestions and tried it.

did a fresh grafana installation 10.0.3 changed into the plugin directory and entered the "mage" command.

the message in response is that : No .go files marked with the mage build tag in this directory will be glad to test any additional recommendation

image
asimpson commented 10 months ago

@Zeevbd to clarify: are you attempting to git clone this repo and run it? or are you attempting to install the plugin through the Grafana plugin catalog?

For the former, you'll need to git clone this repo into your plugins directory and then run mage.

For the later, it should "just work" by installing the plugin via the Plugin UI.

Zeevbd commented 10 months ago

@asimpson, cloned the repo into the plugin folder and ran the "mage" command

then went into the UI and installed the plugin...

the Results: ARM64 file is missing after the "mage" command... and will not be able to use the plugin:

################################################################### Commands and Results ###################################################################

❯ pwd /opt/homebrew/var/lib/grafana/plugins ❯ git clone https://github.com/vertica/vertica-grafana-datasource/ Cloning into 'vertica-grafana-datasource'... remote: Enumerating objects: 361, done. remote: Counting objects: 100% (81/81), done. remote: Compressing objects: 100% (59/59), done. remote: Total 361 (delta 38), reused 32 (delta 16), pack-reused 280 Receiving objects: 100% (361/361), 23.13 MiB | 15.86 MiB/s, done. Resolving deltas: 100% (157/157), done. ❯ ls -lrt total 0 drwxr-xr-x@ 22 zeev.bd admin 704 Aug 16 22:40 vertica-grafana-datasource ❯ cd vertica-grafana-datasource ❯ ls -lrt total 1368 -rw-r--r--@ 1 zeev.bd admin 11357 Aug 16 22:40 LICENSE -rw-r--r--@ 1 zeev.bd admin 324 Aug 16 22:40 Magefile.go -rw-r--r--@ 1 zeev.bd admin 13142 Aug 16 22:40 README.md drwxr-xr-x@ 4 zeev.bd admin 128 Aug 16 22:40 config drwxr-xr-x@ 3 zeev.bd admin 96 Aug 16 22:40 coverage -rw-r--r--@ 1 zeev.bd admin 438 Aug 16 22:40 go.mod -rw-r--r--@ 1 zeev.bd admin 21892 Aug 16 22:40 go.sum -rw-r--r--@ 1 zeev.bd admin 232 Aug 16 22:40 jest-runner-serial.js -rw-r--r--@ 1 zeev.bd admin 877 Aug 16 22:40 jest.config.js -rw-r--r--@ 1 zeev.bd admin 2246 Aug 16 22:40 package.json drwxr-xr-x@ 11 zeev.bd admin 352 Aug 16 22:40 pkg drwxr-xr-x@ 22 zeev.bd admin 704 Aug 16 22:40 src -rw-r--r--@ 1 zeev.bd admin 326 Aug 16 22:40 tsconfig.json -rw-r--r--@ 1 zeev.bd admin 619937 Aug 16 22:40 yarn.lock ❯ mage ❯ pwd /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource ❯ pwd /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource ❯ ls -lrt total 0 ❯ cd .. ❯ pwd /opt/homebrew/var/lib/grafana/plugins ❯ ls -lrt total 0 drwxr-xr-x@ 15 zeev.bd admin 480 Aug 16 22:41 vertica-grafana-datasource ❯ cd vertica-grafana-datasource ❯ ls -lrt total 125128 -rw-r--r--@ 1 zeev.bd admin 3007 Aug 16 22:41 MANIFEST.txt -rw-r--r--@ 1 zeev.bd admin 1733 Aug 16 22:41 plugin.json -rwxr-xr-x@ 1 zeev.bd admin 11796480 Aug 16 22:41 gpx_vertica-grafana-plugin_linux_arm64 -rwxr-xr-x@ 1 zeev.bd admin 12378624 Aug 16 22:41 gpx_vertica-grafana-plugin_windows_amd64.exe -rw-r--r--@ 1 zeev.bd admin 11357 Aug 16 22:41 LICENSE -rw-r--r--@ 1 zeev.bd admin 541886 Aug 16 22:41 module.js -rwxr-xr-x@ 1 zeev.bd admin 13230752 Aug 16 22:41 gpx_vertica-grafana-plugin_darwin_amd64 drwxr-xr-x@ 13 zeev.bd admin 416 Aug 16 22:41 img -rwxr-xr-x@ 1 zeev.bd admin 12374016 Aug 16 22:41 gpx_vertica-grafana-plugin_linux_amd64 -rw-r--r--@ 1 zeev.bd admin 1828149 Aug 16 22:41 module.js.map -rwxr-xr-x@ 1 zeev.bd admin 11862016 Aug 16 22:41 gpx_vertica-grafana-plugin_linux_arm -rw-r--r--@ 1 zeev.bd admin 13142 Aug 16 22:41 README.md -rw-r--r--@ 1 zeev.bd admin 2510 Aug 16 22:41 module.js.LICENSE.txt /opt/homebrew/v/li/g/pl/vertica-grafana-datasource stable ❯ ❯ pwd 22:46:06 /opt/homebrew/var/lib/grafana/plugins ❯ git clone https://github.com/vertica/vertica-grafana-datasource/ Cloning into 'vertica-grafana-datasource'... remote: Enumerating objects: 361, done. remote: Counting objects: 100% (81/81), done. remote: Compressing objects: 100% (59/59), done. remote: Total 361 (delta 38), reused 32 (delta 16), pack-reused 280 Receiving objects: 100% (361/361), 23.13 MiB | 15.86 MiB/s, done. Resolving deltas: 100% (157/157), done. ❯ ls -lrt total 0 drwxr-xr-x@ 22 zeev.bd admin 704 Aug 16 22:40 vertica-grafana-datasource ❯ cd vertica-grafana-datasource ❯ ls -lrt total 1368 -rw-r--r--@ 1 zeev.bd admin 11357 Aug 16 22:40 LICENSE -rw-r--r--@ 1 zeev.bd admin 324 Aug 16 22:40 Magefile.go -rw-r--r--@ 1 zeev.bd admin 13142 Aug 16 22:40 README.md drwxr-xr-x@ 4 zeev.bd admin 128 Aug 16 22:40 config drwxr-xr-x@ 3 zeev.bd admin 96 Aug 16 22:40 coverage -rw-r--r--@ 1 zeev.bd admin 438 Aug 16 22:40 go.mod -rw-r--r--@ 1 zeev.bd admin 21892 Aug 16 22:40 go.sum -rw-r--r--@ 1 zeev.bd admin 232 Aug 16 22:40 jest-runner-serial.js -rw-r--r--@ 1 zeev.bd admin 877 Aug 16 22:40 jest.config.js -rw-r--r--@ 1 zeev.bd admin 2246 Aug 16 22:40 package.json drwxr-xr-x@ 11 zeev.bd admin 352 Aug 16 22:40 pkg drwxr-xr-x@ 22 zeev.bd admin 704 Aug 16 22:40 src -rw-r--r--@ 1 zeev.bd admin 326 Aug 16 22:40 tsconfig.json -rw-r--r--@ 1 zeev.bd admin 619937 Aug 16 22:40 yarn.lock ❯ mage ❯ ls -lrt total 0 ❯ pwd /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource

######################################################## ########################################################

logs:

logger=plugin.loader t=2023-08-16T22:41:52.237705+03:00 level=info msg="Plugin registered" pluginID=vertica-grafana-datasource logger=plugin.loader t=2023-08-16T22:41:52.241619+03:00 level=error msg="Could not start plugin" pluginId=vertica-grafana-datasource err="fork/exec /opt/homebrew/var/lib/grafana/plugins/vertica-grafana-datasource/gpx_vertica-grafana-plugin_darwin_arm64: no such file or directory" /

if the file: gpx_vertica-grafana-plugin_darwin_arm64 is not created, it will not work....

################################################################## ################################################################## Waiting for Tanvi to create the missing file:

Zeevbd commented 10 months ago

Hi Tanvi... any updates on the Driver?

Thanks Ze'ev

tanvipise commented 10 months ago

Hi Ze'ev, this is going to take some time to resolve. I have uploaded my code to my tpise branch in this repo, Grafana team is reviewing it for errors. We cannot guarantee a completion date as this is an open-source project where contributors are free to create any feature/bug fixes via submitting a PR.

asimpson commented 10 months ago

@Zeevbd sorry for being MIA for a bit. Your report is super strange to me, I've done the same steps on an M1 machine and the Darwin ARM binary was generated.

Let's try something else :crossed_fingers:

Hopefully this works. Please report back the results :pray:

That's the earliest version that contained the patch to build for darwin arm. It shouldn't cause any issues with your existing set up. The correct, long-term solution is to upgrade the entire plugin to use the latest create plugin tools, but this should at least get you out of this current jam.

Zeevbd commented 9 months ago

@asimpson thanks for responding back: so i cloned the plugin again, followed your 4 bullet steps above and..

image

got the needed file !!! encompassed in yellow. now if i copy the file to the plugin directory, Grafana will lock the plugin as it was modified...

so i added the remark under /grafana.ini file to: allow_loading_unsigned_plugins = vertica-grafana-datasource and restarted the service:

but the logs say that it would not load the plugin

logger=plugin.loader t=2023-09-02T10:37:16.450858+03:00 level=warn msg="Skipping loading plugin due to problem with signature" pluginID=vertica-grafana-datasource status=modified

and the plugin on Grafana shows:

image

any idea how to bypass ? :)

asimpson commented 9 months ago

@Zeevbd great, that's progress!

That config line needs to be in the [plugins] section.

Is that the case? Also what version of Grafana are you using again?

Zeevbd commented 9 months ago

@asimpson that is correct, the added line :

allow_loading_unsigned_plugins = vertica-grafana-datasource

is under [plugin ] section in grafana.ini

i have installed the latest version: 10.1.2 using : brew install grafana

asimpson commented 9 months ago

I just tested this on a new git clone and any changes from default settings I put in conf/custom.ini which I'll include in full here:

[log]
level = "debug"

[paths]
plugins = /home/adam/Projects/tmp/plugins

[plugins]
allow_loading_unsigned_plugins = vertica-grafana-datasource

And here's how it looks when I go to use the plugin:

image

Are there any differences with how I have things configured here with your config?

Zeevbd commented 9 months ago

have you copied the the file: gpx_vertica-grafana-plugin_darwin_arm64 to the plugin directory?

and used the configuration:. ? [log] level = "debug"

[paths] plugins = /home/adam/Projects/tmp/plugins

[plugins] allow_loading_unsigned_plugins = vertica-grafana-datasource

because on my machine the plugin was blocked

image

asimpson commented 9 months ago

Nope, the plugin directory is the parent directory which contains the plugin. The full path to the plugin is:

home/adam/Projects/tmp/plugins/vertica-grafana-datasource

Zeevbd commented 9 months ago

Correct, i was referring to the full path of the plugin directory, which is under the "vertica-grafana-datasource" directory. after copying the new created file: gpx_vertica-grafana-plugin_darwin_arm64 under the full path of the plugin directory i observed that the plugin changed to a "disabled" mode , like sent on the upper screen shot.

so how to your opinion can we proceed from this stage?

we have created the needed file: _gpx_vertica-grafana-plugin_darwinarm64 but now we need Grafana to recognize the modified plugin and able to work with it..

asimpson commented 9 months ago

i was referring to the full path of the plugin directory, which is under the "vertica-grafana-datasource" directory. after copying the new created file: gpx_vertica-grafana-plugin_darwin_arm64 under the full path of the plugin directory i observed that the plugin changed to a "disabled" mode , like sent on the upper screen shot.

You shouldn't copy the built binary anywhere. Move the entire vertica-grafana-datasource repo/directory under the plugins path. Run mage and yarn build. Restart Grafana, the plugin should no longer be disabled.

If you hover on the Disabled message, is there a tooltip?

Zeevbd commented 9 months ago

The yarn build fails on dependencies

❯ yarn build yarn run v1.22.19 warning package.json: "dependencies" has dependency "react-autosuggest" with range "^10.1.0" that collides with a dependency in "devDependencies" of the same name with version "^9.4.3" error vertica-grafana-plugin@2.1.0: The engine "node" is incompatible with this module. Expected version ">=14". Got "12.22.12" error Commands cannot run with an incompatible environment.

tanvipise commented 8 months ago

Hi Ze'ev,

We have a new version of the plugin released yesterday. It is verified and signed by Grafana. And it also has the binary distribution for M1 and M2 and we have tested it. Please feel free to check it out and let us know for any comments. I am closing this issue as it is fixed.

Thanks, Tanvi

Zeevbd commented 8 months ago

Hi Tanvi. have downloaded and checked. It is perfectly working !!!

Thank you very much for the support and solution. Ze'ev