search

verygoodsecurity / starlarky

VGS edition of Google's safe and hermetically sealed Starlark language - a non-Turing complete subset of Python 3.
https://vgs.dev
Apache License 2.0
28 stars 38 forks source link

Remove VGS Alias formats from StarLarky #186

Open fshaikh-vgs opened 3 years ago

fshaikh-vgs commented 3 years ago

https://github.com/verygoodsecurity/starlarky/commit/ea0adcf80548c42e15d41e815d4237040d956fe9#diff-cf5faff91ae9cd74b7b9d2504673969166da7d94e0b519c53f7b0dfaa2fd856f

This seems like a misplaced validation. The StarLarky repo should not care about the names of VGS alias formats. It should just have an interface that handles exceptions in case the runtime determines that the alias format is not supported.

Having to update StarLarky every time a new Alias format is created does not seem like an appropriate workflow.

mahmoudimus commented 3 years ago

Are you planning on exposing to customers the alias formats via Larky? If so, can it be an enum that you can override by passing in a string until larky is updated?

mahmoudimus commented 3 years ago

Is this issue asking to remove the validation or asking to remove alias format lists from Larky all together?

fshaikh-vgs commented 3 years ago

The ask is to remove the list of alias formats from Larky completely. I do not want to update VaultModule.java in the StarLarky repo when we release new alias formats.

Larky will get a response from the Vault (or some other service that is responsible for responding to the vault module) if the alias format was not appropriate.