Forecast high is always 72F

victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS

https://bonjourr.fr

GNU General Public License v3.0

900 stars 104 forks source link

Forecast high is always 72F #256

Closed robster2001 closed 9 months ago

robster2001 commented 9 months ago

Describe the bug During the day, when the forecast displays the forecast high temperature, it's always showing 72F instead of the correct forecast.

To Reproduce Simply have the forecast displayed on the Bonjourr home page.

Expected behavior It should show correct forecast high.

Screenshots See attached. Today's forecast is for a high of 59F in my area. Screenshot 2023-12-01 093157

Device (please complete the following information):

OS: Windows 11 Beta 22635.2776
Browser: Chrome 119.0.6045.200

victrme commented 9 months ago

Hi @robster2001

Oops 😅 When re-writing forecast in the previous version, I left this old condition if current_forecast < new_forecast, which result in the forecast not updating when days are getting colder !

Thanks for opening this issue, it will be fixed !

Gitoffthelawn commented 9 months ago

And just like that, @victrme solved global warming for all humankind! 🌍 ❤️

robster2001 commented 9 months ago

I just got 1.18.4 and can confirm this is fixed. Thanks.