victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
900 stars 104 forks source link

Chinese localization seems not up-to-date #272

Closed baozidai closed 8 months ago

baozidai commented 8 months ago

Describe the bug The Chinese localization seems not up-to-date in 1.18.4. It is different with Main branch. 图片 In this above image it shows one localization not that good. So I checked the repo finding it's well translated in zh_CN/translations.json, also good in zh_HK.

To Reproduce Steps to reproduce the behavior:

  1. Go to a new tab.
  2. Change language to Chinese.
  3. I'm not sure how to make this pop up again, sorry. If anyone know please point that out.
  4. See the translated text.

Expected behavior There is good translation in the localization file zh_CN/translations.json, such as:

    "Love using Bonjourr? Consider giving us a review or donating, that would help a lot! 😇": "喜欢使用 Bonjourr 吗?考虑给我们评论或捐赠,这会很有帮助!😇",
    "Review": "评论", # in the image above it showed as "审查" which is wrong.
    "Donate": "捐赠", # <-should be this, rather "捐" in image above.

It is expected to be text in the zh_CN/translations.json(the commit 9758ed6), but NO. I don't understand why.

Device (please complete the following information):

victrme commented 8 months ago

Hi @baozidai !

I manually publish updates so the main branch is not always up to date with the version published. The latest release tag should always be what is currently published though.

baozidai commented 8 months ago

Just immature advice. How about trying auto CI/CD for publishing new release? With the Github action firefox-addon-action, this can be tried out to automatically release in a single channel like Firefox addon release and save your time. I would be happy to fork and try this if there is approval or consideration of this approach.

victrme commented 8 months ago

I appreciate your willingness to contribute, but publishing to Firefox is the easiest part. There is a lot more with the changelogs and other platforms that cannot be automated.

It takes about ~15min which is way less than the time it would require to automate it all ! 😄