Disable the ESC key binding.

victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS

https://bonjourr.fr

GNU General Public License v3.0

880 stars 104 forks source link

Disable the ESC key binding. #316

Open gynet opened 5 months ago

gynet commented 5 months ago

Is there any way to disable the ESC binding? Context: I am a Vim user with a browser extension enabled.

victrme commented 5 months ago

Hi @gynet, right now there is no way to disable the keybinding, but we'll focus on keybinding soon enough.

How do you use vim and bonjourr at the same time ? Are you using online.bonjourr.fr, or is there a way to have both extension at the same time ?

gynet commented 5 months ago

I am using Floorp, surfingkeys + new tab override

victrme commented 5 months ago

I see, pretty cool combo. With new tab override, what URL did you set ?

Is it https://online.bonjourr.fr or moz-extension://60b72b62-6127-432f-8ce4-0fc5d5f92f10/index.html ?

If you used the extension, using surfingkeys on top of it is not possible since extension have to be isolated from each other for security reasons...

Using https://online.bonjourr.fr, I don't see any issue with the 'ESC' binding. I don't know anything about vim keybindings so I might be wrong.

gynet commented 5 months ago

@victrme

using https://online.bonjourr.fr
I added many links and sometimes use surfingkeys to select one of them using the F key. I often press ESC twice. In regular Vim environment, it does not have any side effects but, in this case, it will pop the config settings.

victrme commented 5 months ago

OK, that's not so bad, I thought it was preventing you from accessing something !

As I mentioned in my first comment, we'll add keybindings and a way to configure them. I said "soon enough" but it is actually medium/low priority for now, so no false promises.