victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
880 stars 104 forks source link

Save button for the unsplash wallpaper #317

Open baozidai opened 5 months ago

baozidai commented 5 months ago

Is your feature request related to a problem? Please describe. When I get rolled a nice image from unsplash, I want to save it, but I can't found it :( Now I can only get to the site of the photogragher, but can't find the image.

Describe the solution you'd like Add a button for save current unsplash image to local computer. It can be a low priority feature maybe.

rajarshikhatua100 commented 5 months ago

just tap the name of the wallpaper in the bottom left corner it will redirect you to the unsplash website and you can download it from there

baozidai commented 5 months ago

Don't close this issue. I found a localisation problem. In zh_CN, there is no "photo"-like word to indicate that you can access the photo. Left corner shows "拍摄者 " which means "photographer is " but in en_us shows "Photo by " which "Photo" notice you can click it. I hope you can understand the above misunderstanding. I will fix the translation soon.

baozidai commented 5 months ago

What I want it's "图片 由 !someone! 拍摄". In this way it just like "Photo by !someone!" in English which "Photo" mapping to "图片" then it click-able. But I can not make it by only editing the localization because of the tail "拍摄".

Honestly,it is OK there is not "拍摄", but it will be strange in Chinese.

victrme commented 5 months ago

I see. There is a similar issue with the weather forecast in Russian, which means we'll have to improve the way full sentences are translated.

It shouldn't be too complex, however I've started a lot of other things I need to finish first, so that might take some time.

I will @ you in this issue once the new translation method is available !

victrme commented 5 months ago

Hello @baozidai, improved credit translation is here! Is this translation correct ?

image

baozidai commented 5 months ago

@victrme Absolutely right! Thanks for your efforts!

Gitoffthelawn commented 3 months ago

I keep coming back to this feature request, and I just wanted to mention I think it has potential.

@rajarshikhatua100 is correct: one can click on the link and download the background image from the source. But that's an extra step (and more MBs for people on slow/metered connections).

My purpose of posting is just to mention that I think a "save" button for the background may be worthwhile. Another possibility could be to add right-click functionality (on the link that opens the background's source page) that quickly downloads the image.

In any case, I don't think it's a big priority, but this keeps coming up in my feed because I keep thinking about it and wanted to mention my thoughts... and now I have. 😄

victrme commented 3 months ago

I agree it does save a few clicks and page loads! I think we can add a small download icon that appears when you hover your mouse over the credits.

We also have some ideas regarding right clicks, so that might also be added in the future!

ChainsLunatic commented 2 months ago

@victrme would something like that do the job?

victrme commented 2 months ago

Hi @ChainsLunatic, there are a few things to change, but this is the expected behavior !

First, I was thinking more of an icon rather than text. That way we don't need to translate it and it takes less space.

Second is how we trigger a download. We have to follow the guidelines for triggering a download, which means instead of using the slug, we need to use the download_location field. You can access the endpoint using apiFetch:

const download = await apiFetch("/unsplash/photos/<photo_id>/download?ixid=")
ChainsLunatic commented 2 months ago

Allright, thanks for your feedback! I'll look into it :)