search

victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
1.01k stars 116 forks source link

Ability to set custom quotes source #373

Closed ChainsLunatic closed 5 months ago

ChainsLunatic commented 6 months ago

Describe the solution you'd like I would love to be able to set a custom url as quotes source. Either with CSV-Data or the APIs JSON format, I do not really care. I would try to implement it myself but as there is currently work being done on the quotes feature I better wait so that the changes do not interfere.

victrme commented 6 months ago

Hi @babajmcfly,

I took some time respond because I wondered about how to implement this feature in the UI. I don't want to add another input because it's already pretty crowded... I think that a user adding a URL in the custom quotes input would fetch that URL and find a CSV.

However since this is a network related feature, it might be trickier to implement than it seems. You can create a first draft if you want !

ChainsLunatic commented 5 months ago

Hi @victrme,

the custom quotes input is hidden if the user did not select custom. Would it be okay if this rule also applies to a new input? As using the csv textarea would be rather hacky.

victrme commented 5 months ago

Yes that would work! We can add a 4th option in the