search

victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
836 stars 99 forks source link

Quick links - Links per row not working #375

Open barongi opened 1 month ago

barongi commented 1 month ago

Describe the bug Cannot set more than 2 Quick links side by side on my phone.

To Reproduce Steps to reproduce the behavior:

  1. Go to Quick links
  2. Go to Links per row
  3. Move slider to the right
  4. No more than two Quick link icons appear side by side

Expected behavior Expected to see three, then four, then five etc Quick link icons when moving the slider to the right The plan being having a screen showing only Quick links and nothing else.

Screenshots Screenshot_20240526_082556_Kiwi Browser

Ignore the weird links, I just added gibberish links to see what happens with more Quick links.

Device (please complete the following information):

victrme commented 1 month ago

Sorry about that @barongi,

When adding folders, I essentially kept the "desktop" borders, which are too big on mobile and squeeze the links to the center. You should be able to fix this issue by adding this as custom CSS:

#link-list {
  padding: 0
}
victrme commented 1 month ago

Also this will be fixed in the next update.

barongi commented 1 month ago

Thank you very much for the CSS-trick.

I noticed a couple more things: when filling the screen with Quick links the screen doesn't scroll down to show them all. It's stuck on just showing the ones visible. I expected to be able to add like 50-60 or more and then just scroll down to reach all of them. Maybe the custom CSS wasn't even supposed to do that? I hope the scrolling will be a feature in the future.

Also, when creating or editing a folder, if the folder is located on the top row, the editing window goes too far up and gets cut off. I also have problems naming the folders, the "apply changes" text area seems to be very small to click on. It takes me easily 5-6 times before I hit it correctly and the folder gets named. I do have a glass screen protector, not sure if that's what's doing it. My fingers are not huge either =)

Screenshot_20240602_101834_Kiwi Browser (Medium) Screenshot_20240602_101848_Kiwi Browser (Medium)

These are my findings so far. Thank you very much for this extension, it really is amazing on phones since most (if not all) phone browsers have startpages that are complete garbage.

victrme commented 1 month ago

Thank you for liking Bonjourr and your kind words 🙏

The editing window position and the size of its buttons should already be fixed and ready for the next (major) update!

I tried to recreate your settings by adding a lot of folders, but I had no issue scrolling up and down. What behavior do you have when trying to scroll? Nothing happens, or something unexpected?

barongi commented 1 month ago

I didn't try it with lots of folders, only Quick links. So when I had filled up all the screen estate with links and added a few more they were of course "cut off" down at the bottom of the screen. I expected to just scroll down to make them visible but the view wouldn't scroll. So I just organized them all in folders instead and was hoping the scrolling would be implemented in a future update, which apparently it will, according to you. This will be fantastic. A scrollable view is a must for people who don't use folders but instead like to have a bucketload of links on the screen. You know, the kind of people that fill their Windows desktops to the max =) This extension makes the user experience on compatible android browsers so much better, thank you once again!