victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
836 stars 99 forks source link

Implement Dockerfile #377

Closed ChainsLunatic closed 1 month ago

ChainsLunatic commented 1 month ago

An implementation of a Dockerfile using node:lts-slim and nginx:stable-alpine with specific package script online:docker to run the build process with target online prod inside docker build.

victrme commented 1 month ago

Thanks @ChainsLunatic, it works really well !

Can you write small instructions in the Readme after "Running Bonjourr locally"? I know barely enough Docker to run a container, it will be better explained coming from you! Also you don't have to worry about formatting.

ChainsLunatic commented 1 month ago

@victrme I've updated the readme and rearranged it a bit to stay in context. I hope the changes are okay. Should I add more detail or is this enough?

Maybe we could set up GitHub actions to deploy the image to dockerhub. But this would need your involvement as it would be best to use victrme/bonjourr as an image tag.

victrme commented 1 month ago

I think this is enough, thanks!

I messed up my username when registering for docker hub, and now "victrme" is no longer available... 😅😅 The repo will be named "bonjourr/bonjourr".

I don't think we need to setup Github actions because I'm already manually pushing updates to various web stores. I prefer spending 2 more minutes on a simple push than having one more automation to think about!

ChainsLunatic commented 1 month ago

@victrme Allrighty, maybe the example tag in the Readme shall be bonjourr/bonjourr then too?

I'm more a "automate as much as possible with as much control as possible" guy myself. If this workflow is the best for thats allright nonetheles :D If you every wish to make all of those pushes a little more automated or just e.g. combined lemme know :)

victrme commented 1 month ago

Good idea, Readme has been updated.

Understandable, if I could automate everything I would!

Thanks for your help, it is really appreciated! I'll ping you if we need some Github actions 🫡