search

victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
1k stars 116 forks source link

"New Tab Icon" does not replace favicon #420

Closed proactivematter closed 2 months ago

proactivematter commented 2 months ago

Describe the bug Using an emoji in the "New tab icon" setting does not replace the bonjourr favicon, only the tab title.

Expected behavior Using an emoji as the first character changes the tab icon (favicon). Adding text after the emoji changes tab title.

Screenshots Screenshot 2024-09-02 at 07 14 34

Device (please complete the following information):

victrme commented 2 months ago

We made a mistake @proactivematter ! There is supposed to be a small input next to the tab title input for you to add the emoji, but it is always hidden for some reason...

It is already fixed, and the next update should come in a week or two !

wealstarr commented 2 months ago

@victrme Thank you for the fix.

Is it possible to use a custom .svg file as favicon for the Bonjourr tab ?

In the newer configuration of vertical tabs, only the favicon shows on the tab and get lost which was the new tab as bonjourr icon is more like a website favicon than the glyph browser icons used.

Any help will be greatly appreciated.

Kindanoob1664 commented 2 months ago

@wealstarr if you go down to the bottom, there's an option to import/export settings. you can edit your favicon manually through there (should be ' "favicon": "[whatever]", ')

wealstarr commented 2 months ago

@Kindanoob1664 Thank you for the tip, this could be amazing. Unfortunetely it did not work. I exported my settings as a json file. Opened the json file in Notepad++ , edited the 9th line as: "favicon": "C:\Users\cashback\AppData\Roaming\Zen\Profiles\default\chrome\new-tab-image.svg", But when I tried to import it back, nothing happens. I tried to import it as text, nothing happens. I reverted the changes, file was successfuly imported and all settings applied.

Could it be the path that gave broke the file ? Please little guidance here, will be highly appreciated.

victrme commented 2 months ago

favicon only accepts emojis for now !

wealstarr commented 2 months ago

@victrme

Will it be possible to make it accept svg and ico files in the future ?

proactivematter commented 2 months ago

Fixed in 2.0.0. Thanks!