victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
936 stars 108 forks source link

Open Link in New Tab for QuickLinks results in about:blank tab Safari 18.0 MacOS Sequoia 15.0 #457

Open alannwhite opened 1 week ago

alannwhite commented 1 week ago

Describe the bug Open in new tab (or newtab true) breaks functionality for Search Bar and Quick Links settings and results in about:new loading in new tab instead of desired link.

To Reproduce Steps to reproduce the behavior in Safari 20 on Macbook Pro Sequoia 15:

  1. Go to Bonjourr settings
  2. Select Open New Tab in Quick Links settings (or "linknewtab": true, )
  3. Click on the favicon link in Quick Links section
  4. Go to new tab opened
  5. See blank tab loaded with URL "about:blank"

Expected behavior Would expect to see the quicklink selection (e.g., Amazon.com) open in the new tab

Screenshots If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

Copy of CSS: { "about": { "browser": "safari", "version": "20.0.0" }, "showall": true, "lang": "en", "dark": "system", "favicon": "", "tabtitle": "", "greeting": "Alan", "pagegap": 1, "pagewidth": 1600, "time": true, "main": true, "dateformat": "us", "background_blur": 7, "background_bright": 0.8, "background_type": "unsplash", "quicklinks": true, "textShadow": 0.725, "announcements": "all", "review": -1, "css": "", "hide": {}, "linkstyle": "medium", "linktitles": true, "linkbackgrounds": true, "linknewtab": true, "linksrow": "6", "linkspcqibe": { "_id": "linkspcqibe", "order": 1, "title": "Insta", "url": "https://instagram.com", "parent": "Social" }, "linkscpjfrc": { "_id": "linkscpjfrc", "order": 4, "title": "TeenVoice", "url": "https://www.teenvoice.com", "parent": "Most Common" }, "linksfojfce": { "_id": "linksfojfce", "order": 1, "title": "X", "url": "https://x.com/home", "parent": "Most Common", "icon": "https://api.bonjourr.fr/favicon/blob/https://x.com" }, "linksjlpaff": { "_id": "linksjlpaff", "order": 1, "title": "Hulu", "url": "https://www.hulu.com", "parent": "Streaming" }, "linksfpoalm": { "_id": "linksfpoalm", "order": 0, "title": "Netflix", "url": "https://www.netflix.com", "parent": "Streaming" }, "linkspqrori": { "_id": "linkspqrori", "order": 0, "title": "TikTok", "url": "https://tiktok.com", "parent": "Social" }, "linkslprklf": { "_id": "linkslprklf", "order": 2, "title": "Facebook", "url": "https://www.facebook.com", "parent": "Social", "icon": "https://api.bonjourr.fr/favicon/blob/https://facebook.com" }, "linksdiepdp": { "_id": "linksdiepdp", "order": 0, "title": "WSJ", "url": "https://wsj.com", "parent": "Most Common" }, "linksekrjie": { "_id": "linksekrjie", "order": 1, "title": "HBR", "url": "https://hbr.org", "parent": "Reading" }, "linksrgoihf": { "_id": "linksrgoihf", "order": 2, "title": "Prime Video", "url": "https://www.amazon.com/gp/video/storefront", "parent": "Streaming" }, "linksgdrimb": { "_id": "linksgdrimb", "order": 4, "title": "Disney+", "url": "https://www.disneyplus.com", "parent": "Streaming" }, "linkshjpkco": { "_id": "linkshjpkco", "order": 0, "title": "Reddit", "url": "https://www.reddit.com", "parent": "Reading" }, "linksjmqlpi": { "_id": "linksjmqlpi", "order": 2, "title": "LinkedIn", "url": "https://linkedin.com", "parent": "Most Common" }, "linkslacmkf": { "_id": "linkslacmkf", "order": 3, "title": "Max", "url": "https://max.com", "parent": "Streaming" }, "linkscjbamj": { "_id": "linkscjbamj", "order": 3, "title": "Amazon", "url": "https://www.amazon.com", "parent": "Most Common" }, "linkgroups": { "on": true, "synced": [], "pinned": [], "selected": "Most Common", "groups": [ "Most Common", "Streaming", "Reading", "Social" ] }, "clock": { "size": 1.125, "analog": false, "timezone": "auto", "ampm": true, "seconds": false }, "analogstyle": { "hands": "modern", "border": "#ffff", "face": "none", "shape": "round", "background": "#fff2" }, "worldclocks": [], "unsplash": { "collection": "", "lastCollec": "day", "every": "hour", "time": 1727615025286 }, "weather": { "unit": "imperial", "city": "Boston", "provider": "", "moreinfo": "accu", "temperature": "actual", "forecast": "auto", "ccode": "US", "geolocation": "precise" }, "notes": { "on": true, "opacity": 0.1, "text": "## Notes to Myself for Followup\n\n[ ] With markdown titles, lists, and checkboxes\n[ ] Learn more on https://bonjourr.fr/docs/overview", "align": "left", "width": 40 }, "searchbar": { "on": true, "newtab": false, "engine": "google", "placeholder": "Search Google Results", "request": "", "suggestions": true, "opacity": 0.1 }, "quotes": { "on": false, "author": true, "frequency": "day", "type": "inspirobot", "last": 1727614356020 }, "font": { "size": "14", "system": true, "family": "", "weight": "300", "weightlist": [] }, "move": { "layouts": { "single": { "grid": [ [ "time" ], [ "main" ], [ "notes" ], [ "searchbar" ], [ "quicklinks" ], [ "quotes" ] ], "items": {} }, "double": { "grid": [ [ "time", "time" ], [ "main", "main" ], [ "searchbar", "searchbar" ], [ "notes", "quicklinks" ] ], "items": {} }, "triple": { "grid": [ [ ".", "time", "." ], [ ".", "main", "." ], [ ".", "quicklinks", "." ] ], "items": {} } }, "selection": "double" } }

victrme commented 17 hours ago

Hi @alannwhite !

The latest version of Safari "fixed" a workaround I found to allow opening links in a new tab from an extension. Might be for privacy reasons...

We've removed the option on the Safari extension for now. It works on https://online.bonjourr.fr/ though!

Note for myself: it might be possible to add a tabs optional permission to open in a new tab programmatically instead.