victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS
https://bonjourr.fr
GNU General Public License v3.0
994 stars 113 forks source link

The links disappeared after 20.1.1 #458

Closed guidc closed 1 month ago

guidc commented 1 month ago

The links disappeared after this last update. Brazilian Portuguese version. Links should appear in the highlighted area in the image. fgjfj

ZeZekeZ commented 1 month ago

Same with US English version, all of mine are just... gone

Gitoffthelawn commented 1 month ago

Yep... v20.1.1 needs a hotfix!

At first, I thought it was related to https://github.com/victrme/Bonjourr/issues/428, but now I'm thinking maybe it's everyone?

victrme commented 1 month ago

Sorry @Gitoffthelawn, @ZeZekeZ, @guidc, and everyone else...

Can you share your configs? 20.1.1 was already an hotfix based on issue some people had on Telegram, but it seems to be an issue still.

ZeZekeZ commented 1 month ago

bonjourr-20.1.1 2024-10-01 23_18_01.json

LimitedEdiition commented 1 month ago

This happened to me on Firefox. Chrome is working fine. Worst part is, I can't even add new ones. It's like they're invisible.

victrme commented 1 month ago

Yes, they are not gone, just hidden. Can you share your config @LimitedEdiition ?

@ZeZekeZ, can you try to import the config you sent me ? It might fix it. The issue in your config is that linkgroups.selected is set to "" when it should be "default"

ZeZekeZ commented 1 month ago

Yes, they are not gone, just hidden. Can you share your config @LimitedEdiition ?

@ZeZekeZ, can you try to import the config you sent me ? It might fix it. The issue in your config is that linkgroups.selected is set to "" when it should be "default"

That worked! Thanks so much!!!

LimitedEdiition commented 1 month ago

bonjourr-20.1.1 2024-10-01 01_41_35.json

This is my file, could you let me know which line in the json I should change to allow it to show again?

victrme commented 1 month ago

bonjourr-LimitedEdition.json

Here is your config file fixed @LimitedEdiition, you can import it and it should work perfectly! Your linkgroups.selected line is actually missing...

huangvincent170 commented 1 month ago

After the update, my links also all disappeared. Manually adding linkgroups.selected = "default" worked to restore them, thanks!

victrme commented 1 month ago

The reason why I keep having problems since 20.0 with links is that old settings are not deleted properly. It means that Bonjourr is trying to upgrade settings that were already upgraded last update, creating a conflict.

This fix will properly remove old settings. After that everything should be smooth sailing !

I'm sorry for everyone affected, it's not a fun place to be in 😅

Faskil commented 1 month ago

I'm having the same issue but unfortunately, I can't edit the settings. When I add the line with linkgroups.selected, "apply changes" remain greyed out. Basically any modification I make in the field is not taken into account. I'm using the latest Firefox.

victrme commented 1 month ago

It needs to be a valid JSON line @Faskil. The line should look like this:

{
  "selected": "default",
}
Faskil commented 1 month ago

Yeah, that's what I did. But whatever modification I make, "apply changes" remains not clickable. I managed to import the .json from another browser (Edge) but any modification I make in Firefox, I cannot "apply".

victrme commented 1 month ago

You can paste your changes in this website to see if it is valid JSON: https://jsonformatter.curiousconcept.com/

Faskil commented 1 month ago

It is, like I said: when I export the .json from Edge and import it in Firefox, it works. It's when I'm trying to edit the .json directly in the box in the settings, I can't get "Apply changes" to be clickable, whatever change I make.

victrme commented 1 month ago

Even if you change "lang": to "en"or "fr" ?

Faskil commented 1 month ago

Hmm OK now it seems to work. 🤪 I must have done something wrong. Sorry for the inconvenience.

juanjgit commented 1 month ago

This worked for me (v20.1.1):

My links are back

victrme commented 1 month ago

Indeed, you might not even need to add a random link !

victrme commented 1 month ago

Alright, links should be working for everyone with this new patch 20.1.2. Available in Chrome and Firefox right now 👍

guidc commented 1 month ago

Nice, now it's working, thanks! Using the brazilian portuguese version on Firefox.

Gitoffthelawn commented 1 month ago

@victrme I was offline for a bit after my post on this. Because you released 20.1.2 (thank you :heart:), and it seems to be working great, there is no need for any of the above workarounds now, correct?

victrme commented 1 month ago

Yes, the last update essentially did those steps automatically, so no need !

Gitoffthelawn commented 1 month ago

Yes, the last update essentially did those steps automatically, so no need !

Thank you!

I think this issue can likely be closed now.

gpolkga commented 1 month ago

I am still having this problem with 20.1.2. My setup is Chrome with Ubuntu 24.04.
After running a number of tests though, my problem seems to be related to browser permissions that are needed to add Groups (or possibly just synced groups).

If, for example, after doing a fresh install of Bonjourr, I first start a group import and accept Chrome's request for permissions, I can then import my saved .json with no problem. I don't even need to follow through with the group import - just accept the permissions.

If I don't add the permission step, then after importing my .json, I have a blank (except for bg) screen.

victrme commented 1 month ago

Hello @gpolkga! I think this is an issue closer to this one I found: https://github.com/victrme/Bonjourr/issues/434