Search Bar - Suggestions API is called even if "suggestions": false - Githubissues

victrme / Bonjourr

Minimalist & lightweight startpage inspired by iOS

https://bonjourr.fr

GNU General Public License v3.0

998 stars 115 forks source link

Search Bar - Suggestions API is called even if "suggestions": false #466

Closed amengus87 closed 4 weeks ago

amengus87 commented 1 month ago

Describe the bug Hello 👋 Awesome work you have done!

I'm encountering an error : Bonjourr API is called on search bar event if "suggestions": false

To Reproduce Steps to reproduce the behavior:

Go to 'Bonjourr'
Enable 'Search Bar'
Disable 'Suggestions'
Go to network monitor
Type anything in the search bar
API is called

Expected behavior API must not being called when suggestions are off

Screenshots

Device (please complete the following information):

OS: macOS
Browser Safari
Version 18.0

victrme commented 1 month ago

Good catch @amengus87 ! This request doesn't do anything because it is only requesting a websocket connexion that is never used (see status 101). It is wasteful though so this will be fixed, thanks !