search

vim-erlang / vim-erlang-compiler

Erlang syntax checking and compiler plugin for Vim
https://vim-erlang.github.io
56 stars 24 forks source link

(#25) rebar3: include finds files in <app>/include #41

Closed dcy closed 6 years ago

dcy commented 6 years ago

In rebar, we might have the following files:

app/include/xx.hrl
app/src/subsir/xx.erl

xx.erl may contain include("xx.hrl"). This works in rebar, and now it also works in vim-erlang-compiler.

hcs42 commented 6 years ago

Is it intentional that the new commit doesn't contain only one of the changes in the original commit (the rebar lock part)?

dcy commented 6 years ago

Original commit have conflict because i use rebase by wrong way. I make a new one.

hcs42 commented 6 years ago

You rebased correctly, so I merged the PR. I didn't notice that the change that is present only on the original commit (the rebar lock part) was already inlcuded in an existing commit (bcdb1de8aeee2b1b1b7baf4162321d16efd092d0).

Thanks!