search

vincaslt / vscode-highlight-matching-tag

Highlights matching opening or closing tag in VSCode
https://marketplace.visualstudio.com/items?itemName=vincaslt.highlight-matching-tag
MIT License
158 stars 16 forks source link

Hangs vscode for minutes on large codgen'd *.ts file #141

Open gjbadros opened 2 years ago

gjbadros commented 2 years ago

Does this really need to run on .ts files? When I open a 56kloc codegen'd graphql types file, vscode hangs for several minutes due to this extension, and there are obviously no tags to match in a .ts file.

Maybe a setting could disable the functionality on a per file extension basis and by default it shouldn't operate on files without tags?

vincaslt commented 2 years ago

It dosan't assume the file type, it runs on any text. I suppose having an option do siable on file basis would be useful.

On Fri, Apr 15, 2022, 21:01 Greg Badros @.***> wrote:

Does this really need to run on .ts files? When I open a 56kloc codegen'd graphql types file, vscode hangs for several minutes due to this extension, and there are obviously no tags to match in a .ts file.

Maybe a setting could disable the functionality on a per file extension basis and by default it shouldn't operate on files without tags?

— Reply to this email directly, view it on GitHub https://github.com/vincaslt/vscode-highlight-matching-tag/issues/141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHGUV53NQJDKUWEHS7OLR3VFGVHZANCNFSM5TQ6UJGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tjx666 commented 2 years ago

It would be better to alow user to configure:

The Activation Events would better to be onStartupFinished but not *