search

vincentclaes / datajob

Build and deploy a serverless data pipeline on AWS with no effort.
https://pypi.org/project/datajob/
Apache License 2.0
110 stars 19 forks source link

create dag for stepfunctions workflow #75

Closed vincentclaes closed 3 years ago

vincentclaes commented 3 years ago

69

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 5.52%.

Quality metrics Before After Change
Complexity 0.49 ⭐ 1.18 ⭐ 0.69 👎
Method Length 40.43 ⭐ 47.56 ⭐ 7.13 👎
Working memory 6.92 🙂 8.07 🙂 1.15 👎
Quality 82.19% ⭐ 76.67% ⭐ -5.52% 👎
Other metrics Before After Change
Lines 370 397 27
Changed files Quality Before Quality After Quality Change
datajob/stepfunctions/stepfunctions_workflow.py 87.87% ⭐ 82.60% ⭐ -5.27% 👎
datajob_tests/stepfunctions/test_stepfunctions_workflow.py 70.26% 🙂 66.90% 🙂 -3.36% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
datajob_tests/stepfunctions/test_stepfunctions_workflow.py TestStepfunctionsWorkflow.test_create_tasks_for_orchestration_simple_flow_successfully 0 ⭐ 156 😞 14 😞 55.68% 🙂 Try splitting into smaller methods. Extract out complex expressions
datajob/stepfunctions/stepfunctions_workflow.py StepfunctionsWorkflow._construct_toposorted_chain_of_tasks 10 🙂 104 🙂 10 😞 58.75% 🙂 Extract out complex expressions
datajob_tests/stepfunctions/test_stepfunctions_workflow.py TestStepfunctionsWorkflow.test_create_workflow_with_notification_successfully 0 ⭐ 152 😞 11 😞 60.81% 🙂 Try splitting into smaller methods. Extract out complex expressions
datajob_tests/stepfunctions/test_stepfunctions_workflow.py TestStepfunctionsWorkflow.test_create_tasks_for_orchestration_starts_with_parallel_flow_successfully 0 ⭐ 88 🙂 12 😞 67.06% 🙂 Extract out complex expressions
datajob/stepfunctions/stepfunctions_workflow.py StepfunctionsWorkflow._integrate_notification_in_workflow 1 ⭐ 95 🙂 10 😞 68.70% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!