search

vincentgury / XFShapeView

Create shapes content views from shared code for your mobile apps!
MIT License
40 stars 20 forks source link

Does not appear to be compatible with .NET Standard 2.0 #19

Open marcusts opened 6 years ago

marcusts commented 6 years ago

Can we get the library updated? Thanks!

arielcattaneo commented 6 years ago

Hi. I has clone the repository and migrate then to new shared "standar 2.0" project. Then I had to replace several packages (not all its dependencys) to "standar 2.0" compatible versions. Finally, i had successfully for use the this library on my new xamarin.forms proyect 2.5.

If anyone needed aid whit this, contact me.

acaliaro commented 6 years ago

@arielcattaneo It is very helpfull... could you do a PR to add your changes to this repo?

arielcattaneo commented 6 years ago

Ok, perfect. I Organize my things and do make the "PR".

I will try to have on brief the PR. Bye.

toussam commented 6 years ago

Hi @arielcattaneo ,

How is the PR going on ? I would love to see this control supporting .NET Standard 2.0 to avoid the next warning:

Package 'VG.XFShapeView 1.0.5' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.

I thank you in advance for your response and wish you a great weekend !

arielcattaneo commented 6 years ago

Hi and excuse me, i have left this matter forgotten per lack of time and also since i've have altered a little the original project as to make a PR (urgent fix for the project at that times).

I'm clone the original proyect again and adapt it the "standard 2.0".

toussam commented 6 years ago

Hi @arielcattaneo ,

Coming back to take some news. How are things going on ? :)