search

vincentwolsink / home_assistant_enphase_envoy_installer

This is a HACS custom integration for Enphase Envoys with firmware version 7 and up.
Apache License 2.0
61 stars 12 forks source link

Get relay information from inventory if not existing in device status to support Home owner account #37

Closed catsmanac closed 1 year ago

catsmanac commented 1 year ago

Get relay information from inventory if not existing in device status. Home Owner account users have no access to device status in newer firmware. Only missing information is the forced field.

vincentwolsink commented 1 year ago

Thanks for your PR! One concern, I don't think it is good practise to put an entire block of new logic into an except block. Better to restructure this. I can also do it (some other day) if needed.

catsmanac commented 1 year ago

Thanks for your PR! One concern, I don't think it is good practise to put an entire block of new logic into an except block. Better to restructure this. I can also do it (some other day) if needed.

Makes sense I'll give it another try, (or let you know if I need some coaching)

vincentwolsink commented 1 year ago

I think we can just use the relay info from the inventory and don't expose the forced property. Makes things way simpler.