Prevent recursive calls for EnvoyData

[mnederlof]

Hopefully this will prevent recursive calls more definitively, if they occur, we'd know sooner anyway.

[mnederlof]

Somehow None.get resolves to __main__.EnvoyMeteredWithCT No clue why this happens though

[mnederlof]

Just removed the __getattr__ method completely and updated appropriate calls. Please verify though 😇

[mnederlof]

One thing to remember, is that whenever a AttributeError is raised in a class, which has a __getattr__ method defined in the class, python will call that method to see if it resolves to anything...

Have not verified in python how/where, it is just a observation. If we catch the AttributeError ourselves, we can do something else with it.

[vincentwolsink]

It is pretty hard to see now which calls used the magic getattr and which are regular class variables. There is also a magic getattr in EnvoyReader. Should we remove it there too?

(Btw, if you create a PR from your own fork I cannot contribute to it without merging first.)

[mnederlof]

It is pretty hard to see now which calls used the magic getattr and which are regular class variables. There is also a magic getattr in EnvoyReader. Should we remove it there too?

No not yet, i'm working on another PR that will remove that requirement as well, but that also implies some changes to the __init__.py file and how updates are handled.

[mnederlof]

(Btw, if you create a PR from your own fork I cannot contribute to it without merging first.)

I'll start committing branches to your repo then 😄