vincentwolsink / home_assistant_enphase_envoy_installer

This is a HACS custom integration for Enphase Envoys with firmware version 7 and up.
Apache License 2.0
54 stars 10 forks source link

Add missing places to expose detected envoy model #71

Closed mnederlof closed 11 months ago

mnederlof commented 11 months ago

We might want to use some other value than Metered when the value is not set though. (or just use the None value, which is given by default, if we do not specify a default value in the .get method)

vincentwolsink commented 11 months ago

Seems I missed some places indeed. Didn't remember it is there for all sensor types.

vincentwolsink commented 11 months ago

I think it should be like this (see latest two commits), to keep the model "Inverter" and "Relay".

mnederlof commented 11 months ago

Yes, that's better 😄

vincentwolsink commented 11 months ago

Would be nice if we could also expose the inverter product name. But could not find anything for that yet (also no PN to product name mapping anywhere)

mnederlof commented 11 months ago

Yeah, i thought of that too, but then we'd be creating our own list/mapping of part_num to readable product name. For the ones we're having we could start with that though 😄

Maybe there is something on the enlighten interface somewhere that we could retrospect and/or reproduce, have to look at that later.

mnederlof commented 11 months ago

Yeah, i thought of that too, but then we'd be creating our own list/mapping of part_num to readable product name. For the ones we're having we could start with that though 😄

Maybe there is something on the enlighten interface somewhere that we could retrospect and/or reproduce, have to look at that later.

I could not find anything in the enlighten interface, so my best bet would be to keep a static list

this is my list at least..

800-00654-r08 (Envoy-S-Metered-EU)
800-01736-r02 (IQ7+; IQ7PLUS-72-M-INT)
800-00598-r04 (IQ Relay 1-phase; Q-RELAY-1P-INT)
vincentwolsink commented 11 months ago
800-00656-r06 (Envoy-S-Standard-EU)
800-01359-r02 (IQ8+; IQ8PLUS-72-M-INT)

Although it might be nice to keep the Envoy model as the detected one. Also for (easy) debugging, maybe.